[ferroamp] Binding for Ferroamp 20241010 #17536

basse04 · 2024-10-10T10:17:21Z

This is the binding for local connection to the Ferroamp Energy System

This is the binding for local connection to the Ferroamp Energy System Signed-off-by: Örjan Backsell <orjan.backsell@gmail.com>

Changes done in FerroampHandlerFactory.java Signed-off-by: Örjan Backsell <orjan.backsell@gmail.com>

basse04 · 2024-10-10T11:14:09Z

Hi @lsiepel ,
I have had an system-disc crach, mine SSD got full without telling me before it went totally out of order. So I had to install an entire new OS ( Linux Mint 21.3) and everything else I need. So I thought that the best then was to also create a new branch ( ferroamp_v4).
There was initially problems with Maven, I had an old version installed that mvn locally liked but not the checks as above, this is now solved.
And then a question regarded to that, mvn locally complained and said I shold use Maven 3.8.1, I have now installed Maven 3.8.8 and it seems to work, do you think I should use any later version or will this one be fine?
BR Basse

lsiepel

As it had some passaes before i keep this short. Left comments mainly looking at the readme. Some suggestions need to be adpated on multiple places. The binding is improving, so good to see progress.

bundles/org.openhab.binding.ferroamp/README.md

lsiepel · 2024-10-10T12:58:25Z

bundles/org.openhab.binding.ferroamp/README.md

+| userName        | text    | Username to access the device            | N/A     | yes      | no       |
+| password        | text    | Password to access the device            | N/A     | yes      | no       |
+| hasBattery      | boolean | Is there a battery connected or not?     | N/A     | no       | yes      |
+| ssoS0           | boolean | Is there a first SSO unit connected?     | N/A     | no       | no       |


What is a sso ?

Sso is the connection part between the Pv-panels and the Energy hub. Solar String Optimizer.

In that case change the description, so it is more clear (applies to all four):

Is there a first Solar String Optimizer (SSO) unit connected?

Please, see the new text. This is complicated for me as not English native speaker. I use Google translate sometimes but I can see there shortcomings in the reverse translations.

bundles/org.openhab.binding.ferroamp/README.md

lsiepel · 2024-10-10T13:27:08Z

bundles/org.openhab.binding.ferroamp/README.md

+## Thing
+
+```java
+Thing ferroamp:energyhub:myenergyhub [ hostName="energyhub-ip", userName="myUserName", password="myPassword", hasBattery=false ]


Can you extend the example with other Things

lsiepel · 2024-10-10T13:27:45Z

bundles/org.openhab.binding.ferroamp/README.md

+| eso-battery-energy-produced   | Number:Energy              | R          | Eso Battery Energy Produced              | Total energy produced by ESO, i.e total energy charged |
+| eso-battery-energy-consumed   | Number:Energy              | R          | Eso Battery Energy Consumed              | Total energy consumed by ESO, i.e total energy discharged |
+| eso-soc                       | Number:Dimensionless       | R          | Eso State of Charge                      | State of Charge for ESO |
+| eso-relay-status              | String                     | R          | Eso Relay Status                         | 0 = relay closed, 1 = relay open |


Maybe change this to a Contact itemtype.

lsiepel · 2024-10-10T13:30:16Z

bundles/pom.xml

@@ -484,12 +480,10 @@
    <module>org.openhab.voice.watsonstt</module>
    <module>org.openhab.voice.whisperstt</module>
  </modules>
-


these are unexpected. Only the change on line 145 is expected.

Hm, don't know, but I can see them also in mine fork and in openhab/openhab-addons

I do know and they are unexpected :-)
Please revert all changes and only change the line 145. You can copy paste the contents of:
https://raw.githubusercontent.com/openhab/openhab-addons/refs/heads/main/bundles/pom.xml

Changes done in README.md, 20241010 Örjan Backsell <orjan.backsell@gmail.com>

lsiepel · 2024-10-10T19:26:55Z

bundles/org.openhab.binding.ferroamp/README.md

+| ssoS0           | boolean | Is there a first SSO unit connected?     | N/A     | no       | no       |
+| ssoS1           | boolean | Is there a second SSO unit connected?    | N/A     | no       | no       |
+| ssoS2           | boolean | Is there a third SSO unit connected?     | N/A     | no       | no       |
+| ssoS3           | boolean | Is there a fourth SSO unit connected?    | N/A     | no       | no       |


Is there a system limit to 4 SSO's ? Did you consider to model this parameter as a single number: 0-9 representing the amount of SSO's this way it would be more dynamic?

lsiepel · 2024-10-10T19:31:42Z

bundles/org.openhab.binding.ferroamp/README.md

+
+The following configuration parameters are available.
+
+| Name            | Type    | Description                              | Default | Required | Advanced |


According to the thing-types.xml the eso and esm parameters are missing.

Would be nice if these setting scould be auto detected by the binding instead of manually configuring.

Changed in README.
I will think about auto detect.

lsiepel · 2024-10-10T19:34:53Z

bundles/org.openhab.binding.ferroamp/src/main/resources/OH-INF/thing/ferroamp.xml

+	xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+	xmlns:thing="https://openhab.org/schemas/thing-description/v1.0.0"
+	xsi:schemaLocation="https://openhab.org/schemas/thing-description/v1.0.0 https://openhab.org/schemas/thing-description-1.0.0.xsd">
+	<thing-type id="energyhub">


Both ferroamp.xml and thing-type.xml have the same energyhub thing id. Please remove one.

Done changes in EhubParameters.java, FerroampBindingConstants.java, FerroampChannelConfiguration.java, ferroamp.xml, README.md Signed-off-by: Örjan Backsell <orjan.backsell@gmail.com>

Changes done in: EsmParameters.java EsoParameters.java ferroamp.xml FerroampBindingConstants.java FerroampChannelConfiguration.java README.md SsoParameters.java Signed-off-by: Örjan Backsell <orjan.backsell@gmail.com>

Changes done in README.md Signed-off-by: Örjan Backsell <orjan.backsell@gmail.com>

[ferroamp] Binding for Ferroamp 20241010

b686503

This is the binding for local connection to the Ferroamp Energy System Signed-off-by: Örjan Backsell <orjan.backsell@gmail.com>

basse04 requested a review from a team as a code owner October 10, 2024 10:17

[ferroamp] Binding for ferroamp 20241010

0030117

Changes done in FerroampHandlerFactory.java Signed-off-by: Örjan Backsell <orjan.backsell@gmail.com>

lsiepel added enhancement An enhancement or new feature for an existing add-on new binding If someone has started to work on a binding. For a new binding PR. and removed enhancement An enhancement or new feature for an existing add-on labels Oct 10, 2024

lsiepel requested changes Oct 10, 2024

View reviewed changes

[ferroamp] Binding for ferroamp

e640bc8

Changes done in README.md, 20241010 Örjan Backsell <orjan.backsell@gmail.com>

lsiepel reviewed Oct 10, 2024

View reviewed changes

basse04 added 3 commits October 10, 2024 22:37

[ferroamp] Binding for ferroamp 20241010_1

0c15bca

Done changes in EhubParameters.java, FerroampBindingConstants.java, FerroampChannelConfiguration.java, ferroamp.xml, README.md Signed-off-by: Örjan Backsell <orjan.backsell@gmail.com>

[ferroamp] Binding for ferroamp 20241011

7ae6d7a

Changes done in: EsmParameters.java EsoParameters.java ferroamp.xml FerroampBindingConstants.java FerroampChannelConfiguration.java README.md SsoParameters.java Signed-off-by: Örjan Backsell <orjan.backsell@gmail.com>

[ferroamp] Binding for ferroamp 20241011_1

6526649

Changes done in README.md Signed-off-by: Örjan Backsell <orjan.backsell@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ferroamp] Binding for Ferroamp 20241010 #17536

[ferroamp] Binding for Ferroamp 20241010 #17536

basse04 commented Oct 10, 2024

basse04 commented Oct 10, 2024

lsiepel left a comment

lsiepel Oct 10, 2024

basse04 Oct 10, 2024

lsiepel Oct 10, 2024 •

edited

Loading

basse04 Oct 10, 2024

lsiepel Oct 10, 2024

lsiepel Oct 10, 2024

basse04 Oct 11, 2024

lsiepel Oct 10, 2024

basse04 Oct 10, 2024

lsiepel Oct 10, 2024

lsiepel Oct 10, 2024

lsiepel Oct 10, 2024

basse04 Oct 11, 2024

lsiepel Oct 10, 2024


		The following configuration parameters are available.

		\| Name \| Type \| Description \| Default \| Required \| Advanced \|

[ferroamp] Binding for Ferroamp 20241010 #17536

Are you sure you want to change the base?

[ferroamp] Binding for Ferroamp 20241010 #17536

Conversation

basse04 commented Oct 10, 2024

basse04 commented Oct 10, 2024

lsiepel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lsiepel Oct 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lsiepel Oct 10, 2024 •

edited

Loading