[fmiweather] Add support for edited Scandinavia forecast #17555
+92
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves openhab#17548 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
jlaur
added
enhancement
ssalonen
reviewed
Oct 16, 2024
There was a problem hiding this comment.
Please mention this in the intro paragraph, we could shortly introduce this better forecast model
There was a problem hiding this comment.
Perhaps you or @masipila can help me out a bit here? I only know that it's a different forecast edited by meteorologists, but I'm not into the details.
I can add that when testing with my own location, the two forecasts were exactly the same. When I changed to Helsinki, I could see differences between them.
jlaur
removed
the
additional testing preferred
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #17548