[multiple] Reduce SAT warnings

bundles/org.openhab.binding.airgradient/src/main/java/org/openhab/binding/airgradient/internal/handler/DynamicChannelHelper.java

@@ -58,7 +58,7 @@ private record ConfigurationChannel(String id, String typeId, String itemType) {
         }
     };
 
-    private static final Logger logger = LoggerFactory.getLogger(DynamicChannelHelper.class);
+    private static final Logger LOGGER = LoggerFactory.getLogger(DynamicChannelHelper.class);
 
     public static ThingBuilder updateThingWithConfigurationChannels(Thing thing, ThingBuilder builder) {
         for (ConfigurationChannel channel : CHANNELS) {
@@ -72,7 +72,7 @@ private static void addLocalConfigurationChannel(Thing originalThing, ThingBuild
             ConfigurationChannel toAdd) {
         ChannelUID channelId = new ChannelUID(originalThing.getUID(), toAdd.id);
         if (originalThing.getChannel(channelId) == null) {
-            logger.debug("Adding dynamic channel {} to {}", toAdd.id, originalThing.getUID());
+            LOGGER.debug("Adding dynamic channel {} to {}", toAdd.id, originalThing.getUID());
             ChannelTypeUID typeId = new ChannelTypeUID(BINDING_ID, toAdd.typeId);
             Channel channel = ChannelBuilder.create(channelId, toAdd.itemType).withType(typeId).build();
             builder.withChannel(channel);

bundles/org.openhab.binding.bluetooth.daikinmadoka/src/main/java/org/openhab/binding/bluetooth/daikinmadoka/internal/model/MadokaMessage.java

@@ -35,7 +35,7 @@
 @NonNullByDefault
 public class MadokaMessage {
 
-    private static final Logger logger = LoggerFactory.getLogger(MadokaMessage.class);
+    private static final Logger LOGGER = LoggerFactory.getLogger(MadokaMessage.class);
 
     private int messageId;
     private final Map<Integer, MadokaValue> values;
@@ -93,7 +93,7 @@ public static byte[][] createRequest(BRC1HCommand command, MadokaValue... parame
 
             return chunks;
         } catch (IOException e) {
-            logger.info("Error while building request", e);
+            LOGGER.info("Error while building request", e);
             throw new RuntimeException(e);
         }
     }

bundles/org.openhab.binding.bluetooth.generic/src/main/java/org/openhab/binding/bluetooth/generic/internal/BluetoothChannelUtils.java

@@ -46,7 +46,7 @@
 @NonNullByDefault
 public class BluetoothChannelUtils {
 
-    private static final Logger logger = LoggerFactory.getLogger(BluetoothChannelUtils.class);
+    private static final Logger LOGGER = LoggerFactory.getLogger(BluetoothChannelUtils.class);
 
     public static String encodeFieldID(Field field) {
         String requirements = Optional.ofNullable(field.getRequirements()).orElse(Collections.emptyList()).stream()
@@ -130,7 +130,7 @@ public static void updateHolder(BluetoothGattParser parser, GattRequest request,
         if (fieldType == FieldType.BOOLEAN) {
             OnOffType onOffType = convert(state, OnOffType.class);
             if (onOffType == null) {
-                logger.debug("Could not convert state to OnOffType: {} : {} : {} ", request.getCharacteristicUUID(),
+                LOGGER.debug("Could not convert state to OnOffType: {} : {} : {} ", request.getCharacteristicUUID(),
                         fieldName, state);
                 return;
             }
@@ -144,7 +144,7 @@ public static void updateHolder(BluetoothGattParser parser, GattRequest request,
                 request.setField(fieldName, enumeration);
                 return;
             } else {
-                logger.debug("Could not convert state to enumeration: {} : {} : {} ", request.getCharacteristicUUID(),
+                LOGGER.debug("Could not convert state to enumeration: {} : {} : {} ", request.getCharacteristicUUID(),
                         fieldName, state);
             }
             // fall back to simple types
@@ -154,7 +154,7 @@ public static void updateHolder(BluetoothGattParser parser, GattRequest request,
             case SINT: {
                 DecimalType decimalType = convert(state, DecimalType.class);
                 if (decimalType == null) {
-                    logger.debug("Could not convert state to DecimalType: {} : {} : {} ",
+                    LOGGER.debug("Could not convert state to DecimalType: {} : {} : {} ",
                             request.getCharacteristicUUID(), fieldName, state);
                     return;
                 }
@@ -165,7 +165,7 @@ public static void updateHolder(BluetoothGattParser parser, GattRequest request,
             case FLOAT_IEE11073: {
                 DecimalType decimalType = convert(state, DecimalType.class);
                 if (decimalType == null) {
-                    logger.debug("Could not convert state to DecimalType: {} : {} : {} ",
+                    LOGGER.debug("Could not convert state to DecimalType: {} : {} : {} ",
                             request.getCharacteristicUUID(), fieldName, state);
                     return;
                 }
@@ -176,7 +176,7 @@ public static void updateHolder(BluetoothGattParser parser, GattRequest request,
             case UTF16S: {
                 StringType textType = convert(state, StringType.class);
                 if (textType == null) {
-                    logger.debug("Could not convert state to StringType: {} : {} : {} ",
+                    LOGGER.debug("Could not convert state to StringType: {} : {} : {} ",
                             request.getCharacteristicUUID(), fieldName, state);
                     return;
                 }
@@ -186,7 +186,7 @@ public static void updateHolder(BluetoothGattParser parser, GattRequest request,
             case STRUCT:
                 StringType textType = convert(state, StringType.class);
                 if (textType == null) {
-                    logger.debug("Could not convert state to StringType: {} : {} : {} ",
+                    LOGGER.debug("Could not convert state to StringType: {} : {} : {} ",
                             request.getCharacteristicUUID(), fieldName, state);
                     return;
                 }

bundles/org.openhab.binding.bluetooth.govee/src/main/java/org/openhab/binding/bluetooth/govee/internal/GoveeModel.java

@@ -44,7 +44,7 @@ public enum GoveeModel {
     private final String label;
     private final boolean supportsWarningBroadcast;
 
-    private static final Logger logger = LoggerFactory.getLogger(GoveeModel.class);
+    private static final Logger LOGGER = LoggerFactory.getLogger(GoveeModel.class);
 
     private GoveeModel(ThingTypeUID thingTypeUID, String label, boolean supportsWarningBroadcast) {
         this.thingTypeUID = thingTypeUID;
@@ -71,13 +71,13 @@ public boolean supportsWarningBroadcast() {
                 String uname = name.toUpperCase();
                 for (GoveeModel model : GoveeModel.values()) {
                     if (uname.contains(model.name())) {
-                        logger.debug("detected model {}", model);
+                        LOGGER.debug("detected model {}", model);
                         return model;
                     }
                 }
             }
         }
-        logger.debug("Device {} is no Govee", name);
+        LOGGER.debug("Device {} is no Govee", name);
         return null;
     }
 }

bundles/org.openhab.binding.bluetooth.radoneye/src/main/java/org/openhab/binding/bluetooth/radoneye/internal/RadoneyeDataParser.java

@@ -34,14 +34,14 @@ public class RadoneyeDataParser {
     private static final int EXPECTED_DATA_LEN_V2 = 12;
     private static final int EXPECTED_VER_PLUS = 1;
 
-    private static final Logger logger = LoggerFactory.getLogger(RadoneyeDataParser.class);
+    private static final Logger LOGGER = LoggerFactory.getLogger(RadoneyeDataParser.class);
 
     private RadoneyeDataParser() {
     }
 
     public static Map<String, Number> parseRd200Data(int fwVersion, int[] data) throws RadoneyeParserException {
-        logger.debug("Parsed data length: {}", data.length);
-        logger.debug("Parsed data: {}", data);
+        LOGGER.debug("Parsed data length: {}", data.length);
+        LOGGER.debug("Parsed data: {}", data);
 
         final Map<String, Number> result = new HashMap<>();
 

bundles/org.openhab.binding.daikin/src/main/java/org/openhab/binding/daikin/internal/handler/DaikinBaseHandler.java

@@ -241,7 +241,6 @@ private boolean changeHomekitMode(String homekitmode) throws DaikinCommunication
                 return false;
             }
 
-            boolean changeModeSuccess = false;
             updateState(DaikinBindingConstants.CHANNEL_AC_POWER, OnOffType.from(power));
 
             String newMode = switch (mode) {

bundles/org.openhab.binding.emotiva/src/main/java/org/openhab/binding/emotiva/internal/EmotivaProcessorHandler.java

@@ -226,7 +226,6 @@ private void scheduleConnectRetry(long waitMinutes) {
     private void startPollingKeepAlive() {
         final ScheduledFuture<?> localRefreshJob = this.pollingJob;
         if (localRefreshJob == null || localRefreshJob.isCancelled()) {
-
             Number keepAliveConfig = state.getChannel(EmotivaSubscriptionTags.keepAlive)
                     .filter(channel -> channel instanceof Number).map(keepAlive -> (Number) keepAlive)
                     .orElse(new DecimalType(config.keepAlive));

bundles/org.openhab.binding.enocean/src/main/java/org/openhab/binding/enocean/internal/eep/EEPFactory.java

@@ -46,7 +46,7 @@
 @NonNullByDefault
 public class EEPFactory {
 
-    private static final Logger logger = LoggerFactory.getLogger(EEPFactory.class);
+    private static final Logger LOGGER = LoggerFactory.getLogger(EEPFactory.class);
 
     public static EEP createEEP(EEPType eepType) {
         try {
@@ -70,7 +70,7 @@ public static EEP buildEEP(EEPType eepType, ERP1Message packet) {
             return cl.getConstructor(ERP1Message.class).newInstance(packet);
         } catch (IllegalAccessException | InstantiationException | IllegalArgumentException | InvocationTargetException
                 | NoSuchMethodException | SecurityException e) {
-            logger.error("Cannot instantiate EEP {}-{}-{}: {}",
+            LOGGER.error("Cannot instantiate EEP {}-{}-{}: {}",
                     HexUtils.bytesToHex(new byte[] { eepType.getRORG().getValue() }),
                     HexUtils.bytesToHex(new byte[] { (byte) eepType.getFunc() }),
                     HexUtils.bytesToHex(new byte[] { (byte) eepType.getType() }), e.getMessage());
@@ -80,16 +80,16 @@ public static EEP buildEEP(EEPType eepType, ERP1Message packet) {
     }
 
     private static @Nullable EEPType getGenericEEPTypeFor(byte rorg) {
-        logger.info("Received unsupported EEP teach in, trying to fallback to generic thing");
+        LOGGER.info("Received unsupported EEP teach in, trying to fallback to generic thing");
         RORG r = RORG.getRORG(rorg);
         if (r == RORG._4BS) {
-            logger.info("Fallback to 4BS generic thing");
+            LOGGER.info("Fallback to 4BS generic thing");
             return EEPType.Generic4BS;
         } else if (r == RORG.VLD) {
-            logger.info("Fallback to VLD generic thing");
+            LOGGER.info("Fallback to VLD generic thing");
             return EEPType.GenericVLD;
         } else {
-            logger.info("Fallback not possible");
+            LOGGER.info("Fallback not possible");
             return null;
         }
     }
@@ -155,7 +155,7 @@ public static EEP buildEEP(EEPType eepType, ERP1Message packet) {
             case _4BS: {
                 int db0 = msg.getPayload()[4];
                 if ((db0 & _4BSMessage.LRN_TYPE_MASK) == 0) { // Variation 1
-                    logger.info("Received 4BS Teach In variation 1 without EEP, fallback to generic thing");
+                    LOGGER.info("Received 4BS Teach In variation 1 without EEP, fallback to generic thing");
                     return buildEEP(EEPType.Generic4BS, msg);
                 }
 
@@ -167,7 +167,7 @@ public static EEP buildEEP(EEPType eepType, ERP1Message packet) {
                 int type = ((db3 & 0b11) << 5) + ((db2 & 0xFF) >>> 3);
                 int manufId = ((db2 & 0b111) << 8) + (db1 & 0xff);
 
-                logger.debug("Received 4BS Teach In with EEP A5-{}-{} and manufacturerID {}",
+                LOGGER.debug("Received 4BS Teach In with EEP A5-{}-{} and manufacturerID {}",
                         HexUtils.bytesToHex(new byte[] { (byte) func }),
                         HexUtils.bytesToHex(new byte[] { (byte) type }),
                         HexUtils.bytesToHex(new byte[] { (byte) manufId }));
@@ -229,7 +229,7 @@ public static EEP buildEEP(EEPType eepType, ERP1Message packet) {
 
         byte[] senderId = Arrays.copyOfRange(payload, 12, 12 + 4);
 
-        logger.debug("Received SMACK Teach In with EEP {}-{}-{} and manufacturerID {}",
+        LOGGER.debug("Received SMACK Teach In with EEP {}-{}-{} and manufacturerID {}",
                 HexUtils.bytesToHex(new byte[] { (byte) rorg }), HexUtils.bytesToHex(new byte[] { (byte) func }),
                 HexUtils.bytesToHex(new byte[] { (byte) type }), HexUtils.bytesToHex(new byte[] { (byte) manufId }));
 
@@ -263,22 +263,22 @@ public static SMACKTeachInResponse buildResponseFromSMACKTeachIn(EventMessage ev
 
         byte priority = event.getPayload()[1];
         if ((priority & 0b1001) == 0b1001) {
-            logger.debug("gtw is already postmaster");
+            LOGGER.debug("gtw is already postmaster");
             if (sendTeachOuts) {
-                logger.debug("Repeated learn is not allow hence send teach out");
+                LOGGER.debug("Repeated learn is not allow hence send teach out");
                 response.setTeachOutResponse();
             } else {
-                logger.debug("Send a repeated learn in");
+                LOGGER.debug("Send a repeated learn in");
                 response.setRepeatedTeachInResponse();
             }
         } else if ((priority & 0b100) == 0) {
-            logger.debug("no place for further mailbox");
+            LOGGER.debug("no place for further mailbox");
             response.setNoPlaceForFurtherMailbox();
         } else if ((priority & 0b10) == 0) {
-            logger.debug("rssi is not good enough");
+            LOGGER.debug("rssi is not good enough");
             response.setBadRSSI();
         } else if ((priority & 0b1) == 0b1) {
-            logger.debug("gtw is candidate for postmaster => teach in");
+            LOGGER.debug("gtw is candidate for postmaster => teach in");
             response.setTeachIn();
         }
 

bundles/org.openhab.binding.enocean/src/main/java/org/openhab/binding/enocean/internal/eep/EEPHelper.java

@@ -33,7 +33,7 @@
  */
 @NonNullByDefault
 public abstract class EEPHelper {
-    private static final Logger logger = LoggerFactory.getLogger(EEPHelper.class);
+    private static final Logger LOGGER = LoggerFactory.getLogger(EEPHelper.class);
 
     public static State validateTotalUsage(State value, @Nullable State currentState, Configuration config) {
         EnOceanChannelTotalusageConfig c = config.as(EnOceanChannelTotalusageConfig.class);
@@ -71,10 +71,10 @@ public static State validateTotalUsage(State value, @Nullable State currentState
 
     public static boolean validateUnscaledValue(int unscaledValue, double unscaledMin, double unscaledMax) {
         if (unscaledValue < unscaledMin) {
-            logger.debug("Unscaled value ({}) lower than the minimum allowed ({})", unscaledValue, unscaledMin);
+            LOGGER.debug("Unscaled value ({}) lower than the minimum allowed ({})", unscaledValue, unscaledMin);
             return false;
         } else if (unscaledValue > unscaledMax) {
-            logger.debug("Unscaled value ({}) bigger than the maximum allowed ({})", unscaledValue, unscaledMax);
+            LOGGER.debug("Unscaled value ({}) bigger than the maximum allowed ({})", unscaledValue, unscaledMax);
             return false;
         }
 

bundles/org.openhab.binding.fronius/src/main/java/org/openhab/binding/fronius/internal/api/FroniusHttpUtil.java

@@ -30,7 +30,7 @@
  */
 @NonNullByDefault
 public class FroniusHttpUtil {
-    private static final Logger logger = LoggerFactory.getLogger(FroniusHttpUtil.class);
+    private static final Logger LOGGER = LoggerFactory.getLogger(FroniusHttpUtil.class);
 
     /**
      * Issue a HTTP request and retry on failure.
@@ -82,17 +82,17 @@ public static synchronized String executeUrl(HttpMethod httpMethod, String url,
 
                 if (result != null) {
                     if (attemptCount > 1) {
-                        logger.debug("Attempt #{} successful {}", attemptCount, url);
+                        LOGGER.debug("Attempt #{} successful {}", attemptCount, url);
                     }
                     return result;
                 }
 
                 if (attemptCount >= 3) {
-                    logger.debug("Failed connecting to {} after {} attempts.", url, attemptCount, lastException);
+                    LOGGER.debug("Failed connecting to {} after {} attempts.", url, attemptCount, lastException);
                     throw new FroniusCommunicationException("Unable to connect", lastException);
                 }
 
-                logger.debug("HTTP error on attempt #{} {}", attemptCount, url);
+                LOGGER.debug("HTTP error on attempt #{} {}", attemptCount, url);
                 Thread.sleep(500 * attemptCount);
                 attemptCount++;
             }

bundles/org.openhab.binding.haassohnpelletstove/src/main/java/org/openhab/binding/haassohnpelletstove/internal/HaasSohnpelletstoveJsonDataDTO.java

@@ -21,7 +21,7 @@
  * @author Christian Feininger - Initial contribution
  */
 public class HaasSohnpelletstoveJsonDataDTO {
-    metadata meta = new metadata();
+    Metadata meta = new Metadata();
     boolean prg;
     boolean wprg;
     String mode = "";
@@ -32,9 +32,9 @@ public class HaasSohnpelletstoveJsonDataDTO {
     @SerializedName("ht_char")
     String htChar = "";
     @SerializedName("weekprogram")
-    private wprogram[] weekprogram;
+    private Wprogram[] weekprogram;
     @SerializedName("error")
-    private err[] error;
+    private Err[] error;
     @SerializedName("eco_mode")
     boolean ecoMode;
     boolean pgi;
@@ -98,7 +98,7 @@ public HaasSohnpelletstoveJsonDataDTO getResponse() {
         return this;
     }
 
-    public class metadata {
+    public class Metadata {
         @SerializedName("sw_version")
         String swVersion = "";
         @SerializedName("hw_version")
@@ -119,19 +119,19 @@ public class metadata {
         String ean = "";
         boolean rau;
         @SerializedName("wlan_features")
-        private String[] wlan_features;
+        private String[] wlanFeatures;
 
         public String getNonce() {
             return nonce;
         }
     }
 
-    public class err {
+    public class Err {
         String time = "";
         String nr = "";
     }
 
-    public class wprogram {
+    public class Wprogram {
         String day = "";
         String begin = "";
         String end = "";

bundles/org.openhab.binding.heos/src/main/java/org/openhab/binding/heos/internal/action/HeosActions.java

@@ -40,7 +40,7 @@
 @NonNullByDefault
 public class HeosActions implements ThingActions {
 
-    private static final Logger logger = LoggerFactory.getLogger(HeosActions.class);
+    private final Logger logger = LoggerFactory.getLogger(HeosActions.class);
 
     private @Nullable HeosBridgeHandler handler;
 

bundles/org.openhab.binding.icalendar/src/main/java/org/openhab/binding/icalendar/internal/logic/CommandTag.java

@@ -56,7 +56,7 @@ public class CommandTag {
 
     private static final List<Class<? extends Command>> percentCommandType = Arrays.asList(PercentType.class);
 
-    private static final Logger logger = LoggerFactory.getLogger(CommandTag.class);
+    private static final Logger LOGGER = LoggerFactory.getLogger(CommandTag.class);
 
     private String inputLine;
     private CommandTagType tagType;
@@ -150,15 +150,15 @@ else if (targetState.endsWith("%")) {
 
     public static @Nullable CommandTag createCommandTag(String inputLine) {
         if (inputLine.isEmpty() || !CommandTagType.prefixValid(inputLine)) {
-            logger.trace("Command Tag Trace: \"{}\" => NOT a (valid) Command Tag!", inputLine);
+            LOGGER.trace("Command Tag Trace: \"{}\" => NOT a (valid) Command Tag!", inputLine);
             return null;
         }
         try {
             final CommandTag tag = new CommandTag(inputLine);
-            logger.trace("Command Tag Trace: \"{}\" => Fully valid Command Tag!", inputLine);
+            LOGGER.trace("Command Tag Trace: \"{}\" => Fully valid Command Tag!", inputLine);
             return tag;
         } catch (IllegalArgumentException e) {
-            logger.warn("{}", e.getMessage());
+            LOGGER.warn("{}", e.getMessage());
             return null;
         }
     }