Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[broadlink] Bump junit to 4.13.1 #17579

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 16, 2024

Bumps junit:junit from 4.13 to 4.13.1.

Release notes

Sourced from junit:junit's releases.

JUnit 4.13.1

Please refer to the release notes for details.

Changelog

Sourced from junit:junit's changelog.

Summary of changes in version 4.13.1

Rules

Security fix: TemporaryFolder now limits access to temporary folders on Java 1.7 or later

A local information disclosure vulnerability in TemporaryFolder has been fixed. See the published security advisory for details.

Test Runners

[Pull request #1669:](junit-team/junit#1669) Make FrameworkField constructor public

Prior to this change, custom runners could make FrameworkMethod instances, but not FrameworkField instances. This small change allows for both now, because FrameworkField's constructor has been promoted from package-private to public.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [junit:junit](https://github.com/junit-team/junit4) from 4.13 to 4.13.1.
- [Release notes](https://github.com/junit-team/junit4/releases)
- [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.13.1.md)
- [Commits](junit-team/junit4@r4.13...r4.13.1)

---
updated-dependencies:
- dependency-name: junit:junit
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner October 16, 2024 19:56
@dependabot dependabot bot added the awaiting external dependency Depends on a new version of an external dependency label Oct 16, 2024
@lsiepel
Copy link
Contributor

lsiepel commented Oct 16, 2024

@AntonJansen can you look into this? I now also realise I forgot to ask you to add yourself to the codeowner file for broadlink

@lsiepel lsiepel changed the title Bump junit:junit from 4.13 to 4.13.1 in /bundles/org.openhab.binding.broadlink [broadlink] Bump junit to 4.13.1 Oct 16, 2024
@lsiepel lsiepel added security and removed awaiting external dependency Depends on a new version of an external dependency labels Oct 16, 2024
@AntonJansen
Copy link
Contributor

As I am not the codeowner, I cannot handle this PR. I will check if the change breaks anything.

@AntonJansen
Copy link
Contributor

@lsiepel I checked the change it does not bring any trouble. Since I am not the codeowner, I cannot merge this pull request.

@wborn
Copy link
Member

wborn commented Oct 16, 2024

Succeeded by #17580.

@wborn wborn closed this Oct 16, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 16, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/maven/bundles/org.openhab.binding.broadlink/junit-junit-4.13.1 branch October 16, 2024 20:27
@lsiepel
Copy link
Contributor

lsiepel commented Oct 16, 2024

@lsiepel I checked the change it does not bring any trouble. Since I am not the codeowner, I cannot merge this pull request.

Even as codeowner you can’t merge. It mainly helps to automatically determine a reviewer. And supports maintainers to know who has in depth knowledge about a specific binding.
I’ll create a PR to add you, if that is ok?

regarding this PR it has already been fixed by another follow up PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants