-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial stab at Basic Composition for COVID case report #83
base: master
Are you sure you want to change the base?
Conversation
@@ -7,8 +7,6 @@ name: CI | |||
on: | |||
push: | |||
branches: [ master ] | |||
pull_request: | |||
branches: [ master ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears like it would cause deploy even when PRs are made to master. This doesn't seem correct so I removed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good :D Just a couple Qs
* code = $LNC#76689-9 | ||
* value[x] only CodeableConcept | ||
* valueCodeableConcept 1..1 | ||
* valueCodeableConcept from WhoCrValueSetSexAtBirth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this isn't your work but do you know why does this linked valueset deliberately excludes other
and unknown
when FHIR defaults to all four?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that is because that is what the WHO form that this work is based off specifies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's a stupid value set. @litlfred is following up with WHO on improving it.
* code = http://test.org/obsCode#symptoms // TODO: code not defined in questionnaire either | ||
* value[x] only CodeableConcept | ||
* valueCodeableConcept 1..1 | ||
* valueCodeableConcept from WhoCrValueSetYesNo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The url associated with this value set code does not appear to resolve anywhere?
Is that okay?
alias cs-v2-0136 -> http://terminology.hl7.org/CodeSystem/v2-0136
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also noticed that. It might be just used as an identifier rather than pointing to somewhere real but don't really know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just odd because the url alias below it does point to a real site :|
Therefore I thought it may be a typo. But I guess we don't have the spec for that
* valueQuantity.value 1..1 | ||
* valueQuantity from WhoCrValueSetAgeUnits | ||
|
||
Profile: WhoCrObservationBirthSex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to profile all these observations to have our patient as the subject?
For observations from the QuestionnaireResponse, we should have derivedFrom pointing to the QuestionnaireResponse. However, I think a system might generate these observations directly without using the QR, so we either need two profiles or need to make having the derivedFrom as optional.
This creates the covid19 labarotory result questionnaire profile DSC19-84
This adds the covid19 lab result questionnaire response example DSC19-84
DSC19-84
Some syntax is not supported in the old version DSC1-85
This is the diagnostic profile for the covid19 lab result DSC19-85
The cardinality for the fields should be 1..1 and this has been changed DSC19-85
This will add the organization profiles for the ordering clinic and the test lab DSC19-87 DSC19-88
Incorrect instances were being used in the examples resulting in the meta information not being added to the resources by sushi DSC19-66
This is used in the example bundle for a lab result DSC19-86
The encounter is a required field for the diagnostic report DSC19-87
This is a bundle that will collect all the resources that represent the lab result DSC19-89
These fields indicate the information needed to be given by the user. The existing questionnaire and questionnaireResponse examples end these fields with colons. For consistency these fields should as well. DSC19-84
This field is a questionnaire section divider - no information comes from this field directly DSC19-84
Group related data within the questionnaire to make it a more readable DSC19-84
The loinc code is specific to the clinical relevance of this field. The field display name alone does not hold the relevenat medical context for interpretation DSC19-84
DSC19-78
The encounter was previously based on the base Encounter profile. When applied, this commit will base the encounter on the Case Report hospitalization encounter profile. DSC19-78
DSC19-78
DSC19-78
DSC19-130
DSC19-130
This commit will add an example Observation resource for an unknown Outcome Contacts Followed value DSC19-130
When applied, this commit will remove the Outcome Asymp Date observation profile and add it as an effective date for Outcome Asymp Observation. DSC19-130
This profile is no longer required according to the spec DSC19-130
When applied, this commit will remove the Outcome Lab Date Observation profile and add it as an effective date for Outcome Lab result Observation profile. DSC19-130
This commit will remove Encounter examples from the Observations fsh file DSC19-130
DSC19-130
Co-authored-by: Matt <matthew.dickie@jembi.org>
Co-authored-by: Matt <matthew.dickie@jembi.org>
The one observation was the date on which the admission happened. This refers to the effective DateTime of the observation - not an independant Observation. DSC19-78
This commit will remove the cardinality definition of note from Outcome Contacts Followed observation profile. The base FHIR profile already has a 1..1 cardinality defined DSC19-130
DSC19-78: Case Outcome
The resource example was not resolving DSC19-111
Some cardinalities were incorrect and the case isolation date and case isolation profile has been merged into one DSC-163
One profile is now used for the country and city travelled to and the date of travel DSC19-163
These are no longer used DSC19-163
The details about contacting a case has been merged into one profile. This is the date of cantact the setting and the case id DSC19-78
The condition profile is no longer used as it requiers a patient reference which cannot be provided in this case. The comorbidities are now in the comorbidities profile DSC19-68
Dsc19 78 case report update
touch file to trigger build
@ElliotSilver this is only a draft and still a WIP but I'm attempting to create a minimal composition from the mapping document that the three of us contributed to. For now I've kept it separate from your previous work but we could combine later.
I'm new to all of this to any suggestions or advice you have will be most welcome.