Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cv64a6_imafdch_sv39_wb_config: Fix undefined parameter #2513

Merged
merged 1 commit into from
Oct 23, 2024
Merged

cv64a6_imafdch_sv39_wb_config: Fix undefined parameter #2513

merged 1 commit into from
Oct 23, 2024

Conversation

niwis
Copy link
Contributor

@niwis niwis commented Sep 26, 2024

The parameter CVA6ConfigTechnoCut is undefined and causes elaboration errors. Align this with the other configurations and set it to constant 0.

@github-actions GitHub Actions
Copy link
Contributor

✔️ successful run, report available here.

@JeanRochCoulon JeanRochCoulon enabled auto-merge (squash) September 27, 2024 08:53
@JeanRochCoulon JeanRochCoulon enabled auto-merge (squash) September 27, 2024 16:57
@JeanRochCoulon JeanRochCoulon enabled auto-merge (rebase) September 27, 2024 16:58
@JeanRochCoulon JeanRochCoulon enabled auto-merge (squash) September 27, 2024 16:59
@JeanRochCoulon JeanRochCoulon enabled auto-merge (squash) October 8, 2024 14:42
@JeanRochCoulon JeanRochCoulon enabled auto-merge (squash) October 8, 2024 14:43
@JeanRochCoulon JeanRochCoulon enabled auto-merge (squash) October 22, 2024 20:39
@JeanRochCoulon
Copy link
Contributor

@niwis I cannot merge this PR, the reason is the following one:
GitHub has been configured to permit the merge only when the PR is rebase.
As I have no right to modify your branch, I cannot rebase, and as consequence, I cannot merge.
Can we make a test, can you give me the right to write into your branch ?

@niwis
Copy link
Contributor Author

niwis commented Oct 23, 2024

Hi @JeanRochCoulon, I can't; this only seems to be possible for PRs from user-owned forks, but this one is owned by an organisation. I'll rebase myself.

@niwis
cv64a6_imafdch_sv39_wb_config: Fix undefined parameter
d6de283 
The parameter `CVA6ConfigTechnoCut` is undefined and causes elaboration
errors. Align this with the other configurations and set it to constant `0`.

Signed-off-by: Nils Wistoff <nwistoff@iis.ee.ethz.ch>
auto-merge was automatically disabled October 23, 2024 01:19

Head branch was pushed to by a user without write access

@github-actions GitHub Actions
Copy link
Contributor

❌ failed run, report available here.

@JeanRochCoulon JeanRochCoulon merged commit b4d000b into openhwgroup:master Oct 23, 2024
10 checks passed
@niwis niwis deleted the nw/fix-h-wb-config branch October 23, 2024 04:13
@JeanRochCoulon
Copy link
Contributor

In that case, do you think we can constraint Pulp users to use their personnal account to submit PR? This would permit the rebase, otherwise we need to ask the contributor to rebase manually.

@niwis
Copy link
Contributor Author

niwis commented Oct 23, 2024

Sure, I can do this from now on and will let others know

@JeanRochCoulon
Copy link
Contributor

Perfect ! This will help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeanRochCoulon JeanRochCoulon Awaiting requested review from JeanRochCoulon JeanRochCoulon is a code owner

@zarubaf zarubaf Awaiting requested review from zarubaf zarubaf is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niwis @JeanRochCoulon