Correct Swedish and Finnish public holidays #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When public holidays were added for Sweden in #72, Ascension Day (Swedish: Kristi himmelsfärdsdag) was not included even though it is a holiday in Sweden and is listed as such in both sources cited in
src/holidays/se.yaml. No reason was given for its exclusion. This mistake was seemingly carried over to the data for Finland in #294, as Ascension Day (Finnish: helatorstai, Swedish: Kristi himmelsfärdsdag) is a public holiday in Finland according to the sources cited insrc/holidays/fi.yaml. The data for Finland also incorrectly lists the Swedish name of Midsummer Day (Finnish: juhannuspäivä, Swedish: midsommardagen) as midsommarafton, which means Midsummer Eve (Finnish: juhannusaatto), i.e. the Friday on the day before Midsummer Day. These errors are fixed by this PR.