Replace linear search in ContinuousTabular with binary search - #4098
Open
realmisch wants to merge 2 commits into
Open
Replace linear search in ContinuousTabular with binary search#4098realmisch wants to merge 2 commits into
realmisch wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the sampling algorithm in$\mathcal{O}(\log\ n)$ complexity instead of the $\mathcal{O}(n)$ complexity of the linear search.
ContinuousTabular::samplerelies on two linear searches to locate the corresponding point in the CDF. Since the CDF is monotonically increasing, a binary search can be implemented forEffect
Performance improvements up to 10% have been found with simple cases and identical results for a fixed seed.
Example case is the Jezebel benchmark from ICSBEP running
openmc -s 4with 500 batches and 100,000 particles. The runtimes are averaged over 5 runs for each search algorithm.Checklist
I have followed the style guidelines for Python source files (if applicable)I have made corresponding changes to the documentation (if applicable)I have added tests that prove my fix is effective or that my feature works (if applicable)