Fix post-commit clang-format exit handling - #4100
Merged
Merged
Conversation
GuySten
enabled auto-merge (squash)
September 1, 2026 22:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes a small fix in the bundled post-commit hook for running clang-format. Namely,
git-clang-formatreturns the exit status 1 after a successful formatting update, so the hook should only treat statuses > 1 as a true error. Accounting for this allows the post-commit hook to stage formatting changes and amend the commit as intended. Previously,set -ecaused the hook to exit whengit-clang-formatapplied changes, leaving the commit unformatted and the working tree modified.Checklist
I have run clang-format (version 18) on any C++ source files (if applicable)I have followed the style guidelines for Python source files (if applicable)I have made corresponding changes to the documentation (if applicable)I have added tests that prove my fix is effective or that my feature works (if applicable)