Skip to content

Fix tally indicator position on log-scale colorbars #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paulromano wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix tally indicator position on log-scale colorbars #182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions openmc_plotter/plotgui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -946,18 +946,18 @@ def updateTallyDataIndicatorValue(self, y_val):
return

if self.tally_data_indicator is not None and self.tally_image is not None:
# use norm to get axis value if log scale
if cv.tallyDataLogScale:
y_val = self.tally_image.norm(y_val)

# If indicator value hasn't changed, skip update
if self._last_tally_indicator_value == y_val:
return
self._last_tally_indicator_value = y_val

data = self.tally_data_indicator.get_data()
# Colorbar axes use data coordinates; normalization is only needed
# when mapping the value through the colormap.
self.tally_data_indicator.set_data([data[0], [y_val, y_val]])
dl_color = invert_rgb(self.tally_image.get_cmap()(y_val), True)
normalized_value = self.tally_image.norm(y_val)
dl_color = invert_rgb(
self.tally_image.get_cmap()(normalized_value), True)
self.tally_data_indicator.set_c(dl_color)

if not self._blit_indicator(self.tally_data_indicator, self.tally_colorbar):
Expand All @@ -971,18 +971,18 @@ def updateDataIndicatorValue(self, y_val):
return

if self.data_indicator and self.image is not None:
# use norm to get axis value if log scale
if cv.color_scale_log[cv.colorby]:
y_val = self.image.norm(y_val)

# If indicator value hasn't changed, skip update
if self._last_data_indicator_value == y_val:
return
self._last_data_indicator_value = y_val

data = self.data_indicator.get_data()
# Colorbar axes use data coordinates; normalization is only needed
# when mapping the value through the colormap.
self.data_indicator.set_data([data[0], [y_val, y_val]])
dl_color = invert_rgb(self.image.get_cmap()(y_val), True)
normalized_value = self.image.norm(y_val)
dl_color = invert_rgb(
self.image.get_cmap()(normalized_value), True)
self.data_indicator.set_c(dl_color)

if not self._blit_indicator(self.data_indicator, self.property_colorbar):
Expand Down
Loading