Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SapientML to automl benchmark #630

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

kimusaku
Copy link

SapientML is an AutoML technology that can learn from a corpus of existing datasets and their human-written pipelines, and efficiently generate a high-quality pipeline for a predictive task on a new dataset.

Signed-off-by: Kosaku Kimura <kimura.kosaku@fujitsu.com>
Copy link
Collaborator

@PGijsbers PGijsbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions! I haven't had time to try this out yet, but I do already have a couple questions and suggested changes based on the PR. Please have a look at them.

frameworks/SapientML/exec.py Show resolved Hide resolved
Comment on lines 2 to 3
openml
boto3==1.26.98
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tried it yet, but it looks like the exec file does not depend on these dependencies. What are they for?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have updated the requirements and removed the unwanted dependencies.

@@ -0,0 +1,3 @@
sapientml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please install the framework through the setup.sh script. It allows people to specify versions, source, and so on.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have included framework installation through setup.sh script.

frameworks/SapientML/setup.sh Show resolved Hide resolved
@@ -102,7 +102,7 @@ openml: # configuration namespace for openML.

versions: # configuration namespace for versions enforcement (libraries versions are usually enforced in requirements.txt for the app and for each framework).
pip:
python: 3.9 # the Python minor version that will be used by the application in containers and cloud instances, also used as a based version for virtual environments created for each framework.
python: 3.11 # the Python minor version that will be used by the application in containers and cloud instances, also used as a based version for virtual environments created for each framework.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the framework not 3.9 compatible? Changing this number here will affect all frameworks. While we will raise this over time (and also plan to allow framework-specific definitions for this), we can't currently bump this without ensuring the compatibility for all other frameworks.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Now sapientML is compatible with python 3.9. We have updated the config file.

@PGijsbers PGijsbers added the framework add For issues with a framework to be added label Aug 30, 2024
@PGijsbers
Copy link
Collaborator

@kimusaku Are you still planning to work on this?

@PGijsbers PGijsbers added the Stale Last response by user was long ago label Oct 5, 2024
@kimusaku
Copy link
Author

kimusaku commented Oct 6, 2024

@PGijsbers Yes, we are still working on this, especially in making SapientML Python 3.9-compatible. We will be able to update the PR soon.

@PGijsbers PGijsbers removed the Stale Last response by user was long ago label Oct 6, 2024
* WIP

Signed-off-by: Kosaku Kimura <kimura.kosaku@fujitsu.com>

* Issue fix in setup.sh for SapientML

* Updation of config file as Sapientml supports Python version 3.9

Signed-off-by: HimanshuRRai <himanshu.rai@fujitsu.com>

---------

Signed-off-by: Kosaku Kimura <kimura.kosaku@fujitsu.com>
Signed-off-by: HimanshuRRai <himanshu.rai@fujitsu.com>
Co-authored-by: muhammed-nafi-k-a <muhammednafi.a@fujitsu.com>
Co-authored-by: HimanshuRRai <himanshu.rai@fujitsu.com>
Signed-off-by: HimanshuRRai <himanshu.rai@fujitsu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework add For issues with a framework to be added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants