-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix system and template generator for Espaloma 0.3.* #293
Conversation
… EspalomaTemplateGenerator
…nd template_generator.py
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #293 +/- ##
==========================================
- Coverage 69.35% 67.95% -1.40%
==========================================
Files 5 5
Lines 855 877 +22
==========================================
+ Hits 593 596 +3
- Misses 262 281 +19
☔ View full report in Codecov by Sentry. |
@mikemhenry @ijpulidos : I've finished cleaning up the docs and running local tests. |
Created a new PR with these changes such that we can use the CI secrets from our repo. Supersedes #271
These changes add
template_generator_kwargs
to the system generators.Resolves #245 . Resolves #263 . Resolves #282
TODO