Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ff string #294

Closed
wants to merge 5 commits into from
Closed

Ff string #294

wants to merge 5 commits into from

Conversation

mikemhenry
Copy link
Collaborator

No description provided.

@mikemhenry
Copy link
Collaborator Author

dummy pr for #288 to trick github

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2023

Codecov Report

Patch coverage: 57.14% and project coverage change: +0.11 🎉

Comparison is base (da5e8fa) 69.23% compared to head (e55d2c6) 69.35%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #294      +/-   ##
==========================================
+ Coverage   69.23%   69.35%   +0.11%     
==========================================
  Files           5        5              
  Lines         855      855              
==========================================
+ Hits          592      593       +1     
+ Misses        263      262       -1     
Impacted Files Coverage Δ
...penmmforcefields/generators/template_generators.py 75.08% <57.14%> (+0.16%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ijpulidos
Copy link
Collaborator

Do we need to merge the latest changes from #288 here? the changes are minor, but just to be safe.

@mikemhenry
Copy link
Collaborator Author

Sure not a bad idea, CI is running now and automerge is on

@mikemhenry mikemhenry closed this Jul 28, 2023
@mikemhenry mikemhenry deleted the ff_string branch December 20, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants