Markers shown on Spring application.yml

[timtebeek]

• Fixes Markers are left in all yaml files when running recipes with maven or gradle plugin #51

[timtebeek]

Figured explore traits for rewrite-kubernetes, as the KubernetesParser had been a bit of an odd one up to now. It looks like we're not using the KubernetesParser anywhere, and with Traits recently introduced that seemed the way to go.

I've for now only converted this one recipe that was too eager matching just any yaml file to find missing patterns. With these changes it now only matches Kubernetes resources with at least some kind defined, reusing the older UpdateKubernetesModel visitor, but deprecating the KubernetesParser and KubernetesVisitor, as well as the helper methods in K8s that are perhaps best converted in the future.

I'd welcome a review on the approach as well as implementation details; this was mostly to familiarize myself with Traits such that I can better guide and shape community contributions going forward.

One slight concern with this approach is that we call UpdateKubernetesModel more often, as opposed just once when parsing. But using the KubernetesParser would require us to change the OSS plugins & CLI, which is likely to become troublesome to maintain longer term if we repeat that approach for other yaml based standards like CI systems.

[pstreef]

I don't really know what Traits are yet so I cannot really give much insight here..

[timtebeek]

I don't really know what Traits are yet so I cannot really give much insight here..

Ah thanks for having a brief look; then we'll just assume this is ok to merge, as the tests have been expanded, and I imagine Sam is busy enough as it is wrapping up before his holiday. We can always revise if needed; the contract of the recipes exposed hasn't changed.