-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markers shown on Spring application.yml #52
Conversation
timtebeek
commented
Aug 2, 2024
•
edited
Loading
edited
- Fixes Markers are left in all yaml files when running recipes with maven or gradle plugin #51
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Figured explore traits for rewrite-kubernetes, as the KubernetesParser had been a bit of an odd one up to now. It looks like we're not using the KubernetesParser anywhere, and with Traits recently introduced that seemed the way to go. I've for now only converted this one recipe that was too eager matching just any yaml file to find missing patterns. With these changes it now only matches Kubernetes resources with at least some kind defined, reusing the older I'd welcome a review on the approach as well as implementation details; this was mostly to familiarize myself with Traits such that I can better guide and shape community contributions going forward. One slight concern with this approach is that we call |
I don't really know what |
Ah thanks for having a brief look; then we'll just assume this is ok to merge, as the tests have been expanded, and I imagine Sam is busy enough as it is wrapping up before his holiday. We can always revise if needed; the contract of the recipes exposed hasn't changed. |