assertInstanceOf not converted from JUnit5 to assertJ

[timo-abele]

What's changed?

What's your motivation?

Reproducing an observed conversion miss.

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

I'm not sure with sub recipe should convert this so I am using the best practices recipe as a catch-all.

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[github-actions]

Some suggestions could not be made:

• src/main/java/org/openrewrite/java/testing/junit5/EnclosedToNested.java
  • lines 24-25

[timtebeek]

Thanks for the suggestion! This likely needs a dedicated recipe, similar to the other examples seen here:

rewrite-testing-frameworks/src/main/resources/META-INF/rewrite/assertj.yml

Lines 459 to 468 in 8fb11c8

	- org.openrewrite.java.testing.assertj.JUnitAssertArrayEqualsToAssertThat
	- org.openrewrite.java.testing.assertj.JUnitAssertEqualsToAssertThat
	- org.openrewrite.java.testing.assertj.JUnitAssertFalseToAssertThat
	- org.openrewrite.java.testing.assertj.JUnitAssertNotEqualsToAssertThat
	- org.openrewrite.java.testing.assertj.JUnitAssertNotNullToAssertThat
	- org.openrewrite.java.testing.assertj.JUnitAssertNullToAssertThat
	- org.openrewrite.java.testing.assertj.JUnitAssertSameToAssertThat
	- org.openrewrite.java.testing.assertj.JUnitAssertTrueToAssertThat
	- org.openrewrite.java.testing.assertj.JUnitFailToAssertJFail
	- org.openrewrite.java.testing.assertj.JUnitAssertThrowsToAssertExceptionType

Anyone welcome to fill in the missing piece here to make it a reality.