Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add recipe for replacing unnecesary Mockito#eq with direct parameters #615

Merged
merged 15 commits into from
Oct 13, 2024
Merged

Add recipe for replacing unnecesary Mockito#eq with direct parameters #615

merged 15 commits into from
Oct 13, 2024

Commits on Oct 10, 2024

  1. Add recipe for unnecesary Mockito#eq 

    This adds a basic recipe for replacing Mockito#eq with direct parameters in when this is supported.
This change should resolve Sonar issue java:S6068
    @SanderKnauff
    SanderKnauff committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    e06b281 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    @timtebeek @github-actions
    timtebeek and github-actions[bot] authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    cefb3a6 View commit details
    Browse the repository at this point in the history

  3. Drop unnecessary annotations

    @timtebeek
    timtebeek committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    c214d97 View commit details
    Browse the repository at this point in the history

  4. Rename class and apply some first best practices

    @timtebeek
    timtebeek committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    2aed6e7 View commit details
    Browse the repository at this point in the history

  5. Make the tests pass by retaining the prefix

    @timtebeek
    timtebeek committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    1238f62 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2024

  1. Update recipe to also support doThrow#when and BDDMockito#given 

    Also tests methods using Method Matchers.
Also removes the `Mockito#eq` import if it is not required anymore.
    @SanderKnauff
    SanderKnauff committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    4cd1ebd View commit details
    Browse the repository at this point in the history

  2. Format code

    @SanderKnauff
    SanderKnauff committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    f46f39b View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2024

  1. Apply suggested formatting changes

    @timtebeek
    timtebeek committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    150e2cd View commit details
    Browse the repository at this point in the history

  2. Apply suggested formatting changes

    @timtebeek
    timtebeek committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    03ee33d View commit details
    Browse the repository at this point in the history

  3. Inline methods simplified through MethodMatcher

    @timtebeek
    timtebeek committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    9584156 View commit details
    Browse the repository at this point in the history

  4. Cast to MethodCall & replace conditionally

    @timtebeek
    timtebeek committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    38e79ec View commit details
    Browse the repository at this point in the history

  5. Remove unused import

    @timtebeek
    timtebeek committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    dd8aacb View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into autofix-sonar6068

    @timtebeek
    timtebeek authored Oct 13, 2024
    Configuration menu
    Copy the full SHA
    3bebf5c View commit details
    Browse the repository at this point in the history

  7. Collapse if's with similar blocks

    @timtebeek
    timtebeek committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    09a8bb6 View commit details
    Browse the repository at this point in the history

  8. Add SimplifyMockitoVerifyWhenGiven to MockitoBestPractices

    @timtebeek
    timtebeek committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    e9b9552 View commit details
    Browse the repository at this point in the history