Run a subset of best practices against PRs #4232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's your motivation?
Lightly enforce standards with code suggestion comments on PRs.
Anything in particular you'd like reviewers to focus on?
Are we OK enforcing this subset of recipes from rewrite-recommendations/.../META-INF/rewrite/openrewrite.yml?
Any additional context
The full set of recipes is already enforce on most other openrewrite repositories, but not a perfect fit for this repository, which is why I'm only enforcing a subset here.
Direct pushes to main might circumvent these checks, and could then result in additional comments on unrelated PRs. Those are typically easily fixed, but might create some noise unfortunately, which is why I'd held out on these changes up to now.