Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parsing the Metadata field in html using the XML parser #4573

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

lkerford
Copy link
Contributor

We want to be able to parse HTML using the XML parse, this change will enable us to parse the meta table tags

@lkerford lkerford force-pushed the handle-metadata-field-in-html branch 4 times, most recently from 27959da to 70e895e Compare October 11, 2024 18:05
We want to be able to parse HTML using the XML parse, this change will enable us to parse the meta table tags
@lkerford lkerford force-pushed the handle-metadata-field-in-html branch from 70e895e to a65a89e Compare October 11, 2024 22:00
@sambsnyd
Copy link
Member

There are a number of "void" elements in HTML which do not have a closing element. We should probably be able to handle them all alike:
https://html.spec.whatwg.org/multipage/syntax.html#void-elements

@lkerford
Copy link
Contributor Author

There are a number of "void" elements in HTML which do not have a closing element. We should probably be able to handle them all alike:

If we decide to go forward and support all HTML, let make this more tag agnostic. For now lets just support the "meta" tag

@lkerford lkerford merged commit 49df680 into main Oct 11, 2024
2 checks passed
@lkerford lkerford deleted the handle-metadata-field-in-html branch October 11, 2024 23:32
lkerford added a commit that referenced this pull request Oct 11, 2024
sambsnyd pushed a commit that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants