enhancing Java parsers to recover method invocation type attribution when arg types are missing #4596
Conversation
…d type attribution when arg types are missing if there's only one valid signature matching the method name and arg count
|
Hi Nick, I doubt processors will be introduced any time soon since annotation processing is triggered in Saving the |
|
Thanks @nmck257 ! Not sure if you've spoken to Sam about this effort already, but you've at least inspired |
|
yeah, we've had a few pings across mismatched working hours. the |
|
The work there has hardly been tested at all yet. There is basically only a simple test for I have checked that I can run |
|
Or Sam will classload the annotation processor and call the relevant methods, instead, haha. I won't have time this week, but I can throw most of the parsing together over the weekend. |
Getting this exception:
swapping |
|
Thanks for taking a look! @sambsnyd might have some idea or insights. |
|
edit: I've pushed a change to support if it's useful with minimal context, here's an error I got when parsing a file which uses The field it was parsing is the first occurrence of |
(if there's only one valid signature matching the method name and arg count)
What's changed?
see subject
What's your motivation?
Lombok support (#1297) is presumably still far away. In the interim, this PR attempts to "patch over" one hole in type attribution which Lombok repos can introduce.
For example, I frequently work with ( / refactor) code like this:
Sometimes developers will supply those props from a separate Properties class with getters from Lombok, eg,
.propA(lombokPropertyClass.getPropA()). OpenRewrite won't know the type of the getter, because Lombok. That cascades to OpenRewrite not knowing the type of thepropA(...)method invocation. That cascades to OpenRewrite not knowing the type of theselectfor the next method, and so on. If I want to refactorfancyConfig(...), then even if those arg types are known, theselectis unknown, and method matchers miss.Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
maybe @sambsnyd , @knutwannheden
Have you considered any alternatives or workarounds?
Any additional context
It's a draft because I haven't ported to the other JDK versions yet (or tested much beyond the unit tests), and figured I'd solicit feedback first in case there were directional concerns.
Checklist