-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Recipe that allows for the removal/negation of gitignore rules. #4610
Open
Jenson3210
wants to merge
7
commits into
openrewrite:main
Choose a base branch
from
Jenson3210:gitignore_exclusions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rewrite-core/src/main/java/org/openrewrite/ExcludeFileFromGitignore.java
Show resolved
Hide resolved
rewrite-core/src/main/java/org/openrewrite/ExcludeFileFromGitignore.java
Outdated
Show resolved
Hide resolved
rewrite-core/src/main/java/org/openrewrite/ExcludeFileFromGitignore.java
Outdated
Show resolved
Hide resolved
rewrite-core/src/main/java/org/openrewrite/ExcludeFileFromGitignore.java
Outdated
Show resolved
Hide resolved
rewrite-core/src/main/java/org/openrewrite/ExcludeFileFromGitignore.java
Outdated
Show resolved
Hide resolved
rewrite-core/src/main/java/org/openrewrite/ExcludeFileFromGitignore.java
Outdated
Show resolved
Hide resolved
rewrite-core/src/test/java/org/openrewrite/ExcludeFileFromGitignoreTest.java
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Thanks @timtebeek, did not get the time for the suggestions yet today. Would've done it otherwise :) About this build failure... Anyhow pushed a change that uses ctx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Added a recipe
What's your motivation?
First iteration of this seems to work well.
Anyone you would like to review specifically?
@timtebeek as discussed
Have you considered any alternatives or workarounds?
FindAndReplaceText is very restrictive on this. This really uses gitignore rules/logic to determine if a change to the gitignore is necessary.
Any additional context
I've added a workaround for openrewrite/jgit#3
In a next iteration, I want to remove this workaround again once jgit is fixed but guessing we will have some longer checks there.
Planning on 2 later iterations:
Checklist