Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metatags issues #37

Merged
merged 5 commits into from
Jul 1, 2022
Merged

Fix metatags issues #37

merged 5 commits into from
Jul 1, 2022

Conversation

alesma
Copy link

@alesma alesma commented Jun 30, 2022

Hi,

this pr addresses 2 issues

  • Avoid to add the <link rel="alternate" ...> for the default language
  • Prints the correct URL, path.join results in a missing slash after https (e.g. href="https:/openscript.ch/en" from your site) replaced that with simple string concat

@alesma alesma marked this pull request as ready for review June 30, 2022 14:10
@openscript
Copy link
Member

Hi @alesma

Thank you so much for the PR. I will check it out shortly :)

Cheers,
Robin

@alesma
Update I18nHead.tsx
0053353 
added missing trailing slash on root directory URL
@openscript openscript changed the base branch from main to develop July 1, 2022 06:35
@openscript openscript merged commit cd2e467 into openscript-ch:develop Jul 1, 2022
@openscript
Copy link
Member

Thank you very much @alesma for pointing this out and providing a PR.

I've added a unit test for this and refactored the component a bit. If you have the time, I'm very happy if you review these changes here: #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alesma @openscript