Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added catch all triage note. #233

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dblock
Copy link
Member

@dblock dblock commented Oct 21, 2024

Description

Got pinged by @vamshin for an explanation of what these mean.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@amazon.com>
peternied
peternied previously approved these changes Oct 21, 2024
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to document the 'tagging' process a little more in this doc, looks like construction is done ad-hoc during the meeting rather than in this page.

Along those lines I'd recommend modifying the tag used in the meeting to be more self documenting by pointing to the triaging.md

E.g. [Catch All Triage 1 2]

[[Catch All Triage](https://github.com/opensearch-project/.github/blob/main/TRIAGING.md) [1](...) [2](...)]

Thanks for the update

Signed-off-by: dblock <dblock@amazon.com>
@dblock
Copy link
Member Author

dblock commented Oct 21, 2024

Might want to document the 'tagging' process a little more in this doc

I added "How does an issue get triaged". Please re-review! Thanks.

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the update.

Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks dB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants