Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Segment Replication] Update version check for segment replication backpressure rejection stats #10835

Merged
merged 1 commit into from
Oct 23, 2023
Merged

[Segment Replication] Update version check for segment replication backpressure rejection stats #10835

merged 1 commit into from
Oct 23, 2023

Conversation

Rishikesh1159
Copy link
Member

Description

This PR updates version check for segment replication backpressure rejection stats made in #10656 .

This PR should only be merged after #10834 is merged.

Related Issues

Resolves #10501

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Rishikesh1159
Update version check made in PR opensearch-project#10656.
d2958f4 
Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
@github-actions github-actions bot added bug Something isn't working Storage:Remote labels Oct 22, 2023
@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change d2958f4

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@ashking94 ashking94 mentioned this pull request Oct 23, 2023
Closed
@ashking94
Copy link
Member

@mch2 We have a fix one of the frequently failing flaky test here - #10838. This PR is blocked on the MixedClusterClientYAML test failures. Lets merge this so that the flaky test fix PR can be merged as well.

@sachinpkale sachinpkale merged commit ef4b327 into opensearch-project:main Oct 23, 2023
39 of 65 checks passed
@mch2
Copy link
Member

mch2 commented Oct 23, 2023

@mch2 We have a fix one of the frequently failing flaky test here - #10838. This PR is blocked on the MixedClusterClientYAML test failures. Lets merge this so that the flaky test fix PR can be merged as well.

I would prefer not to but we've been trying to get this in all day, so lets go ahead and i'll make sure this passes.

@linuxpi linuxpi mentioned this pull request Oct 23, 2023
Merged
8 tasks
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@Rishikesh1159 @shiv0408
Update version check made in PR opensearch-project#10656. (opensearch…
a82b823 
…-project#10835)

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mch2 mch2 mch2 approved these changes

@sachinpkale sachinpkale sachinpkale approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied

@reta reta Awaiting requested review from reta reta is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@setiah setiah Awaiting requested review from setiah

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
bug Something isn't working skip-changelog Storage:Remote
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Remote Store] Include SegRep and Remote Store Rejections in node/stats api
4 participants
@Rishikesh1159 @ashking94 @mch2 @sachinpkale