Fix a flaky test that relies on terminate_after for an exact count match

[austintlee]

Description

[Describe what this change achieves]

Related Issues

Resolves #10435

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• [ x] Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/28748/
• CommitID: 5f9b631
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Compatibility status:

Checks if related components are compatible with change 5c190c2

Incompatible components

Incompatible components: [https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/alerting.git]

[github-actions]

❌ Gradle check result for 5c190c2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 1fd4fdf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 2c2d4bd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[austintlee]

@reta Can you take another look? I am not sure why I have DCO failing.

[reta]

@reta Can you take another look? I am not sure why I have DCO failing.

@austintlee sure, could you please rebase and squash your changes into single commit? I should resolve the DCO check

[austintlee]

@reta One of the tests is now failing locally with and without concurrent search enabled. I need to look into that. (oh boy)

[reta]

@reta One of the tests is now failing locally with and without concurrent search enabled. I need to look into that. (oh boy)

Oh man, @austintlee is it related to your change? If not, could you share what test you struggle with? Thank you.

[austintlee]

testSimpleTerminateAfterTrackTotalHitsUpToSize

[reta]

testSimpleTerminateAfterTrackTotalHitsUpToSize

It supposed to be fixed, right? Or it looks like we need to re-evaluate the cause?

[austintlee]

@reta strangely, I had a change that was not related to the size=0 case. I reverted it.

Now, my local repo was completely out of sync with upstream so I had to do some git reset and rebase to get my diff to show up correctly and prepared a new PR - #12179. Do you think this can still make the 2.12 train?

[andrross]

I believe this is superseded by #12179 so I'm closing it. Please correct me if I'm wrong @austintlee