Allow index & cluster default refresh interval setting value to be -1

[ashking94]

Description

This PR fixes the bug that does not allow the index setting index.refresh_interval and cluster setting cluster.default.index.refresh_interval to be set to -1. More details on #11410.

Related Issues

Resolves #11410

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Compatibility status:

Checks if related components are compatible with change e111d4f

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git]

[github-actions]

❕ Gradle check result for e0d6240: UNSTABLE

• TEST FAILURES:

      3 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 71.48%. Comparing base (b15cb0c) to head (566fbe0).
Report is 220 commits behind head on main.

Files	Patch %	Lines
...in/java/org/opensearch/indices/IndicesService.java	0.00%	1 Missing and 1 partial ⚠️
...h/cluster/metadata/MetadataCreateIndexService.java	75.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11411      +/-   ##
============================================
+ Coverage     71.42%   71.48%   +0.06%     
- Complexity    59978    60722     +744     
============================================
  Files          4985     5044      +59     
  Lines        282275   285704    +3429     
  Branches      40946    41374     +428     
============================================
+ Hits         201603   204226    +2623     
- Misses        63999    64568     +569     
- Partials      16673    16910     +237     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ashking94]

testPrimaryRelocationWhileIndexing

flaky test - #9191

[ashking94]

❌ Gradle check result for fb11796: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky test - #9891

[github-actions]

❌ Gradle check result for af98af1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❕ Gradle check result for e111d4f: UNSTABLE

• TEST FAILURES:

      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testRequestStats

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[Bukhtawar]

Will prefer a more predictable value rather than disabling a mode meant to perform constant work in the system(segment creation and replication)

[ashking94]

Will prefer a more predictable value rather than disabling a mode meant to perform constant work in the system(segment creation and replication)

Can you elaborate more on this, @Bukhtawar?

[opensearch-trigger-bot]

This PR is stalled because it has been open for 30 days with no activity.

[gbbafna]

@astute-decipher : can you pick this one and rebase it ?

[github-actions]

❌ Gradle check result for e111d4f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[ashking94]

@gbbafna let me do that for you. @astute-decipher might not have the access for it.

[github-actions]

❕ Gradle check result for 566fbe0: UNSTABLE

• TEST FAILURES:

      1 org.opensearch.gateway.RecoveryFromGatewayIT.testShardStoreFetchMultiNodeMultiIndexesUsingBatchAction

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[ashking94]

testShardStoreFetchMultiNodeMultiIndexesUsingBatchAction

Flaky test - #13307