Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a "meta issue" template #12148

Merged
merged 6 commits into from
Feb 7, 2024
Merged

Conversation

CEHENKLE
Copy link
Member

@CEHENKLE CEHENKLE commented Feb 2, 2024

Description

During the 3/31 OpenSearch triage, we noticed that we had several meta issues that didn't have enough details for someone who wasn't working on the project to understand what was trying to be accomplished.

This template attempts to capture the conversation around "goodness" of a meta ticket here: https://opensearch.slack.com/archives/C05L60S4UBT/p1706720978192339

Related Issues

No related issue

Check List

  • New functionality includes testing.
  • All tests pass
  • New functionality has been documented.
  • New functionality has javadoc added
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CEHENKLE Thanks for building this up - give us a baseline quality on our meta issues that will be easy for the community to engage with and if we do see meta issues that can be improved, this is a straight forward way to improve an existing issue by recreating it with this template.

Copy link
Contributor

github-actions bot commented Feb 2, 2024

Compatibility status:

Checks if related components are compatible with change a7d64d5

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

github-actions bot commented Feb 2, 2024

✅ Gradle check result for fcd3bf4: SUCCESS

@peternied
Copy link
Member

@CEHENKLE Looks like you had some changes that aren't signed off with the DCO, can you updated these?

@CEHENKLE
Copy link
Member Author

CEHENKLE commented Feb 2, 2024

@CEHENKLE Looks like you had some changes that aren't signed off with the DCO, can you updated these?

D'oh! I'll fix it Monday, thanks :)

Signed-off-by: CEHENKLE <henkle@amazon.com>
Signed-off-by: CEHENKLE <henkle@amazon.com>
Signed-off-by: CEHENKLE <henkle@amazon.com>
Signed-off-by: CEHENKLE <henkle@amazon.com>
Signed-off-by: CEHENKLE <henkle@amazon.com>
Copy link
Contributor

github-actions bot commented Feb 5, 2024

❌ Gradle check result for 5f3da48: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kartg
Copy link
Member

kartg commented Feb 5, 2024

Gradle check failure is from known flaky test #9191

> Task :server:internalClusterTest

Tests with failures:
 - org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

4576 tests completed, 1 failed, 44 skipped
...

Copy link
Contributor

github-actions bot commented Feb 5, 2024

❌ Gradle check result for 5f3da48:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Feb 6, 2024

❌ Gradle check result for 5f3da48: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Feb 7, 2024

❕ Gradle check result for a7d64d5: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (445bf1f) 71.36% compared to head (a7d64d5) 71.46%.
Report is 1 commits behind head on main.

Files Patch % Lines
.../org/opensearch/telemetry/tracing/SpanBuilder.java 95.23% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12148      +/-   ##
============================================
+ Coverage     71.36%   71.46%   +0.09%     
- Complexity    59643    59700      +57     
============================================
  Files          4954     4954              
  Lines        280695   280712      +17     
  Branches      40780    40783       +3     
============================================
+ Hits         200319   200608     +289     
+ Misses        63688    63448     -240     
+ Partials      16688    16656      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peternied peternied merged commit 930ecf0 into opensearch-project:main Feb 7, 2024
30 checks passed
abseth-amzn pushed a commit to abseth-amzn/OpenSearch that referenced this pull request Feb 8, 2024
Signed-off-by: CEHENKLE <henkle@amazon.com>
Co-authored-by: Andrew Ross <andrross@amazon.com>
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 1, 2024
Signed-off-by: CEHENKLE <henkle@amazon.com>
Co-authored-by: Andrew Ross <andrross@amazon.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
Signed-off-by: CEHENKLE <henkle@amazon.com>
Co-authored-by: Andrew Ross <andrross@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Signed-off-by: CEHENKLE <henkle@amazon.com>
Co-authored-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants