Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Metric Framework] Adds support for Histogram metric #12175

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport a4bc4af from #12062.

* [Metric Framework] Adds support for Histogram metric

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Adds test

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Addresses review comments

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Adds change log

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fixed spotless

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fixes javadoc

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fixes javadoc

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fixes test

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Removes explicit approach

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Removes explicit approach

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Addresses review comments

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
(cherry picked from commit a4bc4af)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Feb 5, 2024

Compatibility status:

Checks if related components are compatible with change 45e0c61

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/alerting.git]

Copy link
Contributor

github-actions bot commented Feb 5, 2024

❕ Gradle check result for 45e0c61: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testNonZeroPrimaryStatsOnNewlyCreatedIndexWithZeroDocs
      1 org.opensearch.index.shard.RemoteIndexShardTests.testNoFailuresOnFileReads
      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 146 lines in your changes are missing coverage. Please review.

Comparison is base (4a3c324) 71.09% compared to head (45e0c61) 71.12%.
Report is 8 commits behind head on 2.x.

Files Patch % Lines
...search/repositories/fs/ReloadableFsRepository.java 31.03% 40 Missing ⚠️
...h/index/codec/fuzzy/FuzzyFilterPostingsFormat.java 85.44% 18 Missing and 5 partials ⚠️
...java/org/opensearch/index/shard/StoreRecovery.java 0.00% 18 Missing and 2 partials ⚠️
.../main/java/org/opensearch/index/IndexSettings.java 50.00% 10 Missing ⚠️
...in/java/org/opensearch/index/shard/IndexShard.java 38.46% 7 Missing and 1 partial ⚠️
...ndex/codec/fuzzy/IndexInputImmutableLongArray.java 46.15% 7 Missing ⚠️
.../org/opensearch/index/codec/fuzzy/BloomFilter.java 90.74% 2 Missing and 3 partials ⚠️
...ava/org/opensearch/index/codec/fuzzy/FuzzySet.java 70.58% 2 Missing and 3 partials ⚠️
...c/main/java/org/opensearch/common/cache/Cache.java 89.18% 4 Missing ⚠️
...search/common/cache/tier/TieredSpilloverCache.java 95.78% 1 Missing and 3 partials ⚠️
... and 10 more
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #12175      +/-   ##
============================================
+ Coverage     71.09%   71.12%   +0.03%     
- Complexity    59441    59594     +153     
============================================
  Files          4894     4910      +16     
  Lines        280285   280897     +612     
  Branches      41105    41171      +66     
============================================
+ Hits         199261   199792     +531     
- Misses        64080    64143      +63     
- Partials      16944    16962      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit 4204125 into 2.x Feb 6, 2024
79 checks passed
@github-actions github-actions bot deleted the backport/backport-12062-to-2.x branch February 6, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant