[Backport 2.x][Tiered Caching] Make Indices Request Cache Stale Key Mgmt Threshold … #13413

kiranprakash154 · 2024-04-26T19:06:25Z

Backport f798497 from #12941

…setting dynamic (opensearch-project#12941) * Update IndicesRequestCache.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update ClusterSettings.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update IndicesRequestCacheIT.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * spotless Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update IndicesRequestCacheIT.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * some refactoring Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update IndicesRequestCache.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * address existing tests Signed-off-by: Kiran Prakash <awskiran@amazon.com> * UTs Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update CHANGELOG.md Signed-off-by: Kiran Prakash <awskiran@amazon.com> * ITs Signed-off-by: Kiran Prakash <awskiran@amazon.com> * spotless Signed-off-by: Kiran Prakash <awskiran@amazon.com> * refactor Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update IndicesRequestCacheIT.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update IndicesRequestCacheIT.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update IndicesRequestCacheIT.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update IndicesRequestCacheIT.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update CHANGELOG.md Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update CHANGELOG.md Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update IndicesRequestCacheIT.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update IndicesRequestCache.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update IndicesRequestCacheIT.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * resolve conflicts Signed-off-by: Kiran Prakash <awskiran@amazon.com> * address code comments Signed-off-by: Kiran Prakash <awskiran@amazon.com> * address code comments Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update IndicesRequestCacheIT.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * rename tests Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update IndicesRequestCacheIT.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update IndicesRequestCacheIT.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * resolve conflicts Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update IndicesRequestCache.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * code comments Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update IndicesRequestCacheIT.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> --------- Signed-off-by: Kiran Prakash <awskiran@amazon.com> (cherry picked from commit f798497)

Signed-off-by: Kiran Prakash <awskiran@amazon.com>

github-actions · 2024-04-26T19:15:12Z

❌ Gradle check result for 735a25d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-04-26T19:16:49Z

❌ Gradle check result for b7a70d0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-04-26T20:08:56Z

✅ Gradle check result for 0e7d692: SUCCESS

codecov · 2024-04-26T20:10:40Z

Codecov Report

Attention: Patch coverage is 62.50000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 71.17%. Comparing base (0dd892c) to head (7d3f1ef).
Report is 201 commits behind head on 2.x.

Files	Patch %	Lines
...va/org/opensearch/indices/IndicesRequestCache.java	62.50%	3 Missing and 3 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##                2.x   #13413      +/-   ##
============================================
- Coverage     71.28%   71.17%   -0.12%     
- Complexity    60145    60697     +552     
============================================
  Files          4957     5015      +58     
  Lines        282799   286025    +3226     
  Branches      41409    41797     +388     
============================================
+ Hits         201591   203568    +1977     
- Misses        64189    65195    +1006     
- Partials      17019    17262     +243

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kiran Prakash <awskiran@amazon.com>

github-actions · 2024-04-26T21:41:18Z

✅ Gradle check result for 163d8f9: SUCCESS

github-actions · 2024-04-26T21:45:18Z

❕ Gradle check result for 9592cd3: UNSTABLE

TEST FAILURES:

      2 org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Signed-off-by: Kiran Prakash <awskiran@amazon.com>

github-actions · 2024-04-27T07:37:28Z

❌ Gradle check result for d9d36cd: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-04-27T07:54:48Z

❌ Gradle check result for fe77207: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Kiran Prakash <awskiran@amazon.com>

github-actions · 2024-04-28T21:49:19Z

✅ Gradle check result for eb02b2f: SUCCESS

github-actions · 2024-04-28T22:12:48Z

❕ Gradle check result for 7d3f1ef: UNSTABLE

TEST FAILURES:

      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testReadBlobWithRetries

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

kiranprakash154 · 2024-04-28T22:22:00Z

❕ Gradle check result for 7d3f1ef: UNSTABLE

TEST FAILURES:
      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testReadBlobWithRetries
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Created this issue for flakiness
#13433

kiranprakash154 · 2024-04-28T22:23:57Z

@sohami can u help merge this ?
(cc: @sgup432 @kkhatua )

kiranprakash154 added 4 commits April 26, 2024 12:02

resolve conflicts

b7a70d0

Signed-off-by: Kiran Prakash <awskiran@amazon.com>

Merge branch '2.x' into backport/backport-12941-to-2.x

735a25d

Signed-off-by: Kiran Prakash <awskiran@amazon.com>

remove typo

0e7d692

Signed-off-by: Kiran Prakash <awskiran@amazon.com>

kiranprakash154 changed the title ~~[Tiered Caching] Make Indices Request Cache Stale Key Mgmt Threshold …~~ [Backport 2.x][Tiered Caching] Make Indices Request Cache Stale Key Mgmt Threshold … Apr 26, 2024

kiranprakash154 marked this pull request as ready for review April 26, 2024 20:46

kiranprakash154 requested review from anasalkouz, andrross, Bukhtawar, CEHENKLE, dblock, dbwiddis, dreamer-89, gbbafna, kotwanikunal, mch2, msfroh, nknize, owaiskazi19, reta, Rishikesh1159, sachinpkale, saratvemulapalli, shwetathareja, sohami and tlfeng as code owners April 26, 2024 20:46

kiranprakash154 requested a review from VachaShah as a code owner April 26, 2024 20:46

kiranprakash154 added 2 commits April 26, 2024 13:47

Update IndicesRequestCache.java

163d8f9

Signed-off-by: Kiran Prakash <awskiran@amazon.com>

Update IndicesRequestCache.java

9592cd3

Signed-off-by: Kiran Prakash <awskiran@amazon.com>

kiranprakash154 added 2 commits April 26, 2024 23:57

Update IndicesRequestCache.java

d9d36cd

Signed-off-by: Kiran Prakash <awskiran@amazon.com>

Update IndicesRequestCache.java

fe77207

Signed-off-by: Kiran Prakash <awskiran@amazon.com>

kiranprakash154 added 2 commits April 28, 2024 13:59

Update IndicesRequestCache.java

eb02b2f

Signed-off-by: Kiran Prakash <awskiran@amazon.com>

Update IndicesRequestCache.java

7d3f1ef

Signed-off-by: Kiran Prakash <awskiran@amazon.com>

kiranprakash154 mentioned this pull request Apr 28, 2024

[BUG] AzureBlobContainerRetriesTests.testReadBlobWithRetries is flaky #13433

Closed

kiranprakash154 self-assigned this Apr 29, 2024

sohami approved these changes Apr 29, 2024

View reviewed changes

sohami merged commit a2cf155 into opensearch-project:2.x Apr 29, 2024
27 of 28 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Backport 2.x][Tiered Caching] Make Indices Request Cache Stale Key Mgmt Threshold … #13413

[Backport 2.x][Tiered Caching] Make Indices Request Cache Stale Key Mgmt Threshold … #13413

kiranprakash154 commented Apr 26, 2024 •

edited

Loading

github-actions bot commented Apr 26, 2024

github-actions bot commented Apr 26, 2024

github-actions bot commented Apr 26, 2024

codecov bot commented Apr 26, 2024 •

edited

Loading

github-actions bot commented Apr 26, 2024

github-actions bot commented Apr 26, 2024

github-actions bot commented Apr 27, 2024

github-actions bot commented Apr 27, 2024

github-actions bot commented Apr 28, 2024

github-actions bot commented Apr 28, 2024

kiranprakash154 commented Apr 28, 2024

kiranprakash154 commented Apr 28, 2024

[Backport 2.x][Tiered Caching] Make Indices Request Cache Stale Key Mgmt Threshold … #13413

[Backport 2.x][Tiered Caching] Make Indices Request Cache Stale Key Mgmt Threshold … #13413

Conversation

kiranprakash154 commented Apr 26, 2024 • edited Loading

github-actions bot commented Apr 26, 2024

github-actions bot commented Apr 26, 2024

github-actions bot commented Apr 26, 2024

codecov bot commented Apr 26, 2024 • edited Loading

Codecov Report

github-actions bot commented Apr 26, 2024

github-actions bot commented Apr 26, 2024

github-actions bot commented Apr 27, 2024

github-actions bot commented Apr 27, 2024

github-actions bot commented Apr 28, 2024

github-actions bot commented Apr 28, 2024

kiranprakash154 commented Apr 28, 2024

kiranprakash154 commented Apr 28, 2024

kiranprakash154 commented Apr 26, 2024 •

edited

Loading

codecov bot commented Apr 26, 2024 •

edited

Loading