Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Add support for randomizing Remote Store enabled testing #13845

Merged
merged 3 commits into from
Sep 5, 2024
Merged

[Backport 2.x] Add support for randomizing Remote Store enabled testing #13845

merged 3 commits into from
Sep 5, 2024

Conversation

Rishikesh1159
Copy link
Member

Description

This PR baackports #12488

Related Issues

Resolves #12458 , #12488

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • API changes companion pull request created.
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Rishikesh1159
backport opensearch-project#12488 to 2.x branch.
fb8c0b1 
Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Storage Issues and PRs relating to data and metadata storage labels May 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for fb8c0b1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for fb8c0b1: SUCCESS

@codecov Codecov
Copy link

codecov bot commented May 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.66%. Comparing base (dcdc4d2) to head (a2a2340).
Report is 4 commits behind head on 2.x.

Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #13845      +/-   ##
============================================
+ Coverage     71.55%   71.66%   +0.10%     
- Complexity    64312    64392      +80     
============================================
  Files          5262     5262              
  Lines        301279   301279              
  Branches      43861    43861              
============================================
+ Hits         215574   215900     +326     
+ Misses        67703    67319     -384     
- Partials      18002    18060      +58

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Jun 27, 2024
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Jun 27, 2024
Open
@opensearch-trigger-bot opensearch-trigger-bot bot removed the stalled Issues that have stalled label Jun 28, 2024
@dblock
Copy link
Member

dblock commented Jul 23, 2024

@Rishikesh1159 looks like this may have been missed, can you please rebase and make sure we do merge it to 2.x?

@dblock dblock mentioned this pull request Jul 23, 2024
Merged
8 tasks
@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Aug 25, 2024
@dblock
Copy link
Member

dblock commented Aug 25, 2024

Bumping @Rishikesh1159 and maybe @mch2 to finish this?

@Rishikesh1159
Merge branch '2.x' into backport-12488-2.x
8bb17eb 
Signed-off-by: Rishikesh <62345295+Rishikesh1159@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 8bb17eb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@Rishikesh1159
Fix indentation.
a2a2340 
Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ Gradle check result for a2a2340: SUCCESS

@mch2 mch2 merged commit f85ff03 into opensearch-project:2.x Sep 5, 2024
35 checks passed
sumitasr pushed a commit to sumitasr/OpenSearch that referenced this pull request Sep 6, 2024
@Rishikesh1159 @sumitasr
[Backport 2.x] Add support for randomizing Remote Store enabled testi…
22a9b26 
…ng (opensearch-project#13845)

* backport opensearch-project#12488 to 2.x branch.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* Fix indentation.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

---------

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Signed-off-by: Rishikesh <62345295+Rishikesh1159@users.noreply.github.com>
This was referenced Sep 6, 2024
Open
Open
@prudhvigodithi prudhvigodithi mentioned this pull request Oct 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mch2 mch2 mch2 approved these changes

@kotwanikunal kotwanikunal kotwanikunal approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

Assignees
No one assigned
Labels
enhancement Enhancement or improvement to existing feature or request skip-changelog stalled Issues that have stalled Storage Issues and PRs relating to data and metadata storage
Projects
Storage Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rishikesh1159 @dblock @mch2 @kotwanikunal