Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset discovery nodes in most transport node actions request. (#15131) #15681

Conversation

SwethaGuptha
Copy link
Contributor

Description

Backport #15131 to 2.x

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 7078b1b: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@SwethaGuptha SwethaGuptha force-pushed the node-discovery-backport-15131-to-2.x branch from 7078b1b to 0d2698e Compare September 6, 2024 08:53
Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Gradle check result for 0d2698e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Gradle check result for 0d2698e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…earch-project#15131)

Signed-off-by: Swetha Guptha <gupthasg@amazon.com>
Co-authored-by: Swetha Guptha <gupthasg@amazon.com>
@SwethaGuptha SwethaGuptha force-pushed the node-discovery-backport-15131-to-2.x branch from 0d2698e to b7660db Compare September 6, 2024 12:00
Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Gradle check result for b7660db: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 9, 2024

❌ Gradle check result for b7660db: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 9, 2024

❌ Gradle check result for b7660db: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 924ecd8: SUCCESS

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 60.71429% with 11 lines in your changes missing coverage. Please review.

Project coverage is 71.68%. Comparing base (e5e1bad) to head (924ecd8).
Report is 207 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ices/dangling/list/ListDanglingIndicesRequest.java 0.00% 2 Missing ⚠️
...luster/node/hotthreads/NodesHotThreadsRequest.java 0.00% 1 Missing ⚠️
...on/admin/cluster/node/usage/NodesUsageRequest.java 0.00% 1 Missing ⚠️
...napshots/status/TransportNodesSnapshotsStatus.java 0.00% 1 Missing ⚠️
...ndices/dangling/find/FindDanglingIndexRequest.java 0.00% 1 Missing ⚠️
...rch/action/support/nodes/TransportNodesAction.java 66.66% 0 Missing and 1 partial ⚠️
...ch/gateway/TransportNodesListGatewayMetaState.java 0.00% 1 Missing ⚠️
...y/TransportNodesListGatewayStartedShardsBatch.java 0.00% 1 Missing ⚠️
...es/store/TransportNodesListShardStoreMetadata.java 0.00% 1 Missing ⚠️
...ore/TransportNodesListShardStoreMetadataBatch.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15681      +/-   ##
============================================
+ Coverage     71.48%   71.68%   +0.19%     
- Complexity    62677    64594    +1917     
============================================
  Files          5123     5269     +146     
  Lines        294480   302147    +7667     
  Branches      42912    43979    +1067     
============================================
+ Hits         210518   216589    +6071     
- Misses        66286    67464    +1178     
- Partials      17676    18094     +418     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants