Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Wlm create/update REST API bug fix (#16422) #16440

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

kaushalmahi12
Copy link
Contributor

Backport 2.x for #16422

* test changes

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

* fix the create/update queryGroup REST APIs

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

* undo gradle change

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

* add PR link in CHANGELOG

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

* fix javadoc issues

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

* remove redundant name param

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

* Update CHANGELOG.md

Signed-off-by: Ankit Jain <akjain@amazon.com>

* fix action name in transport class for update query group

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

---------

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Signed-off-by: Ankit Jain <akjain@amazon.com>
Co-authored-by: Ankit Jain <akjain@amazon.com>
Copy link
Contributor

❌ Gradle check result for 72f2dc5: TIMEOUT

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 72f2dc5: TIMEOUT

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 72f2dc5: SUCCESS

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 71.81%. Comparing base (41258e7) to head (72f2dc5).
Report is 2 commits behind head on 2.x.

Files with missing lines Patch % Lines
...in/wlm/action/TransportCreateQueryGroupAction.java 0.00% 5 Missing ⚠️
...in/wlm/action/TransportUpdateQueryGroupAction.java 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #16440      +/-   ##
============================================
+ Coverage     71.77%   71.81%   +0.03%     
- Complexity    65344    65349       +5     
============================================
  Files          5312     5312              
  Lines        304914   304922       +8     
  Branches      44425    44425              
============================================
+ Hits         218861   218974     +113     
+ Misses        67803    67719      -84     
+ Partials      18250    18229      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jainankitk jainankitk merged commit fc4ac8b into opensearch-project:2.x Oct 23, 2024
61 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants