Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/CD] Add E2E Cypress workflow for sql workbench #233

Merged
merged 4 commits into from
Dec 15, 2023

Conversation

RyanL1997
Copy link
Contributor

@RyanL1997 RyanL1997 commented Dec 14, 2023

Description

Add E2E Cypress workflow for sql workbench

Expected failure on Cypress Workflow

Reference to: https://github.com/opensearch-project/dashboards-query-workbench/actions/runs/7216048968/job/19661506355?pr=233#step:20:134

The response we got was:

Status: 406 - Not Acceptable
Headers: {
  "content-type": "application/json; charset=utf-8",
  "osd-name": "fv-az1269-175",
  "cache-control": "private, no-cache, no-store, must-revalidate",
  "vary": "accept-encoding",
  "content-encoding": "gzip",
  "date": "Fri, 15 Dec 2023 00:15:57 GMT",
  "connection": "keep-alive",
  "keep-alive": "timeout=120",
  "transfer-encoding": "chunked"
}
Body: {
  "error": "Content-Type header [application/x-www-form-urlencoded] is not supported",
  "status": 406
}

The above matches the expected failure on #232

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3917540) 53.08% compared to head (8918ee8) 53.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #233   +/-   ##
=======================================
  Coverage   53.08%   53.08%           
=======================================
  Files          33       33           
  Lines        1622     1622           
  Branches      288      288           
=======================================
  Hits          861      861           
  Misses        673      673           
  Partials       88       88           
Flag Coverage Δ
dashboards-query-workbench 53.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
@RyanL1997
Copy link
Contributor Author

The 2.x backport of this PR requires the backport of #232 first

Signed-off-by: Ryan Liang <jiallian@amazon.com>
@ps48 ps48 merged commit c4163bb into opensearch-project:main Dec 15, 2023
9 of 10 checks passed
RyanL1997 added a commit to RyanL1997/dashboards-query-workbench that referenced this pull request Dec 19, 2023
…t#233)

* Add E2E Cypress workflow for sql workbench

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Add debugging statements

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Correct plugins dir

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Correct the name of the step

Signed-off-by: Ryan Liang <jiallian@amazon.com>

---------

Signed-off-by: Ryan Liang <jiallian@amazon.com>
mengweieric pushed a commit that referenced this pull request Dec 19, 2023
* [CI/CD] Add E2E Cypress workflow for sql workbench (#233)

* Add E2E Cypress workflow for sql workbench

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Add debugging statements

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Correct plugins dir

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Correct the name of the step

Signed-off-by: Ryan Liang <jiallian@amazon.com>

---------

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Switch the version for 2.x branch

Signed-off-by: Ryan Liang <jiallian@amazon.com>

---------

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants