-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: add wsl commands to set the vm.max_map_count
#5077
Merged
vagimeli
merged 4 commits into
opensearch-project:main
from
colossus06:colossus06-update-install-opensearch-wsl
Dec 15, 2023
Merged
update: add wsl commands to set the vm.max_map_count
#5077
vagimeli
merged 4 commits into
opensearch-project:main
from
colossus06:colossus06-update-install-opensearch-wsl
Dec 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added commands to set the vm.max_map_count on WSL Windows. Signed-off-by: colossus06 <96833570+colossus06@users.noreply.github.com>
colossus06
requested review from
cwillum,
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
ananzh,
seanneumann,
AMoo-Miki and
natebower
as code owners
September 22, 2023 06:41
Naarcha-AWS
reviewed
Oct 3, 2023
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Hi @Naarcha-AWS , what's the status of this? Are we waiting for a PR that will move the topic? |
vagimeli
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 15, 2023
Added commands to set the vm.max_map_count on WSL Windows. Signed-off-by: colossus06 <96833570+colossus06@users.noreply.github.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: Melissa Vagi <vagimeli@amazon.com> (cherry picked from commit 106a3fc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vagimeli
added a commit
that referenced
this pull request
Dec 15, 2023
Added commands to set the vm.max_map_count on WSL Windows. (cherry picked from commit 106a3fc) Signed-off-by: colossus06 <96833570+colossus06@users.noreply.github.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: Melissa Vagi <vagimeli@amazon.com>
This was referenced Dec 19, 2023
vagimeli
added a commit
that referenced
this pull request
Dec 21, 2023
Added commands to set the vm.max_map_count on WSL Windows. Signed-off-by: colossus06 <96833570+colossus06@users.noreply.github.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: Melissa Vagi <vagimeli@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added commands to set the vm.max_map_count on WSL Windows.
Description
With this change windows users can set the minimum
vm.max_map_count
to install opensearch on WSL.Issues Resolved
This change resolves #5076
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.