Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for the Data Prepper OpenSearch source #5144
Documentation for the Data Prepper OpenSearch source #5144
Changes from 1 commit
7a264ce
82241b3
3de849a
e4f9c58
b56fcc0
7490514
8eb75a9
79eaf06
a74afa6
19e5a4e
abef256
6174965
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 9 in _data-prepper/pipelines/configuration/sources/opensearch.md
GitHub Actions / style-job
Check failure on line 9 in _data-prepper/pipelines/configuration/sources/opensearch.md
GitHub Actions / style-job
Check failure on line 9 in _data-prepper/pipelines/configuration/sources/opensearch.md
GitHub Actions / style-job
Check failure on line 11 in _data-prepper/pipelines/configuration/sources/opensearch.md
GitHub Actions / style-job
Check failure on line 17 in _data-prepper/pipelines/configuration/sources/opensearch.md
GitHub Actions / style-job
Check failure on line 71 in _data-prepper/pipelines/configuration/sources/opensearch.md
GitHub Actions / style-job
Check warning on line 73 in _data-prepper/pipelines/configuration/sources/opensearch.md
GitHub Actions / style-job
Check failure on line 106 in _data-prepper/pipelines/configuration/sources/opensearch.md
GitHub Actions / style-job
Check failure on line 106 in _data-prepper/pipelines/configuration/sources/opensearch.md
GitHub Actions / style-job
Check failure on line 106 in _data-prepper/pipelines/configuration/sources/opensearch.md
GitHub Actions / style-job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to introduce the table?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if the edit shown above works for you.
Check warning on line 119 in _data-prepper/pipelines/configuration/sources/opensearch.md
GitHub Actions / style-job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need to say "instant" here, or can this just be "The time when processing should begin. The source will not start processing until this time"? Same comment re: capitalization of "String". In the previous row, there is an underscore instead of a hyphen between ISO and 8601. Should they match? I don't normally see any punctuation between the two.
Check warning on line 125 in _data-prepper/pipelines/configuration/sources/opensearch.md
GitHub Actions / style-job
Check warning on line 125 in _data-prepper/pipelines/configuration/sources/opensearch.md
GitHub Actions / style-job