-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Including info on OpenID Additional Parameters #5600
Merged
Naarcha-AWS
merged 5 commits into
opensearch-project:main
from
samuelcostae:include-openid-additiona-parameters
Nov 20, 2023
Merged
Including info on OpenID Additional Parameters #5600
Naarcha-AWS
merged 5 commits into
opensearch-project:main
from
samuelcostae:include-openid-additiona-parameters
Nov 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam <samuel.costa@eliatra.com>
samuelcostae
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
ananzh,
seanneumann,
AMoo-Miki and
natebower
as code owners
November 14, 2023 14:10
@scrawfor99 can you follow up and try to get this merged. |
@scrawfor99: I'll work on it now. |
Naarcha-AWS
added
OSCI
An OSCI contribution.
backport 2.11
PR: Backport label for 2.11
labels
Nov 14, 2023
Naarcha-AWS
requested changes
Nov 14, 2023
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Sam <128482925+samuelcostae@users.noreply.github.com>
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Sam <128482925+samuelcostae@users.noreply.github.com>
samuelcostae
force-pushed
the
include-openid-additiona-parameters
branch
from
November 17, 2023 14:41
950c9f8
to
e574d75
Compare
Signed-off-by: Sam <samuel.costa@eliatra.com>
samuelcostae
force-pushed
the
include-openid-additiona-parameters
branch
from
November 17, 2023 14:44
e574d75
to
9b57d19
Compare
Naarcha-AWS
approved these changes
Nov 20, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 20, 2023
* Including info on OpenID Additional Parameters Signed-off-by: Sam <samuel.costa@eliatra.com> * Update _security/authentication-backends/openid-connect.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Sam <128482925+samuelcostae@users.noreply.github.com> * Update _security/authentication-backends/openid-connect.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Sam <128482925+samuelcostae@users.noreply.github.com> * PR feedback changes Signed-off-by: Sam <samuel.costa@eliatra.com> --------- Signed-off-by: Sam <samuel.costa@eliatra.com> Signed-off-by: Sam <128482925+samuelcostae@users.noreply.github.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> (cherry picked from commit 4af8a0d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Naarcha-AWS
added a commit
that referenced
this pull request
Nov 20, 2023
* Including info on OpenID Additional Parameters * Update _security/authentication-backends/openid-connect.md * Update _security/authentication-backends/openid-connect.md * PR feedback changes --------- (cherry picked from commit 4af8a0d) Signed-off-by: Sam <samuel.costa@eliatra.com> Signed-off-by: Sam <128482925+samuelcostae@users.noreply.github.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
@Naarcha-AWS The code change corresponding to this documentation has not been merged. Can we revert this change in 2.11 and include it in the next version release? |
Naarcha-AWS
added a commit
that referenced
this pull request
Nov 28, 2023
This reverts commit 4af8a0d.
Naarcha-AWS
added a commit
that referenced
this pull request
Nov 28, 2023
Simple-Analysis
pushed a commit
to Simple-Analysis/documentation-website
that referenced
this pull request
Nov 29, 2023
vagimeli
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Including info on OpenID Additional Parameters Signed-off-by: Sam <samuel.costa@eliatra.com> * Update _security/authentication-backends/openid-connect.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Sam <128482925+samuelcostae@users.noreply.github.com> * Update _security/authentication-backends/openid-connect.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Sam <128482925+samuelcostae@users.noreply.github.com> * PR feedback changes Signed-off-by: Sam <samuel.costa@eliatra.com> --------- Signed-off-by: Sam <samuel.costa@eliatra.com> Signed-off-by: Sam <128482925+samuelcostae@users.noreply.github.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
vagimeli
pushed a commit
that referenced
this pull request
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4 - Doc review
PR: Doc review in progress
backport 2.11
PR: Backport label for 2.11
OSCI
An OSCI contribution.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Including info on newly added "Additional Parameters" support for Open ID
Issues Resolved
Fixes #5598
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.