Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including info on OpenID Additional Parameters #5600

Conversation

samuelcostae
Copy link
Contributor

@samuelcostae samuelcostae commented Nov 14, 2023

Description
Including info on newly added "Additional Parameters" support for Open ID

Issues Resolved
Fixes #5598

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sam <samuel.costa@eliatra.com>
@stephen-crawford
Copy link
Contributor

@scrawfor99 can you follow up and try to get this merged.

@Naarcha-AWS
Copy link
Collaborator

@scrawfor99: I'll work on it now.

@Naarcha-AWS Naarcha-AWS added OSCI An OSCI contribution. backport 2.11 PR: Backport label for 2.11 labels Nov 14, 2023
@Naarcha-AWS Naarcha-AWS self-assigned this Nov 14, 2023
@Naarcha-AWS Naarcha-AWS added the 4 - Doc review PR: Doc review in progress label Nov 14, 2023
samuelcostae and others added 2 commits November 17, 2023 11:36
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Signed-off-by: Sam <128482925+samuelcostae@users.noreply.github.com>
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Signed-off-by: Sam <128482925+samuelcostae@users.noreply.github.com>
@samuelcostae samuelcostae force-pushed the include-openid-additiona-parameters branch from 950c9f8 to e574d75 Compare November 17, 2023 14:41
Signed-off-by: Sam <samuel.costa@eliatra.com>
@samuelcostae samuelcostae force-pushed the include-openid-additiona-parameters branch from e574d75 to 9b57d19 Compare November 17, 2023 14:44
@Naarcha-AWS Naarcha-AWS merged commit 4af8a0d into opensearch-project:main Nov 20, 2023
3 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 20, 2023
* Including info on OpenID Additional Parameters

Signed-off-by: Sam <samuel.costa@eliatra.com>

* Update _security/authentication-backends/openid-connect.md

Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Signed-off-by: Sam <128482925+samuelcostae@users.noreply.github.com>

* Update _security/authentication-backends/openid-connect.md

Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Signed-off-by: Sam <128482925+samuelcostae@users.noreply.github.com>

* PR feedback changes

Signed-off-by: Sam <samuel.costa@eliatra.com>

---------

Signed-off-by: Sam <samuel.costa@eliatra.com>
Signed-off-by: Sam <128482925+samuelcostae@users.noreply.github.com>
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
(cherry picked from commit 4af8a0d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Naarcha-AWS added a commit that referenced this pull request Nov 20, 2023
* Including info on OpenID Additional Parameters



* Update _security/authentication-backends/openid-connect.md




* Update _security/authentication-backends/openid-connect.md




* PR feedback changes



---------




(cherry picked from commit 4af8a0d)

Signed-off-by: Sam <samuel.costa@eliatra.com>
Signed-off-by: Sam <128482925+samuelcostae@users.noreply.github.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
@cwperks
Copy link
Member

cwperks commented Nov 28, 2023

@Naarcha-AWS The code change corresponding to this documentation has not been merged. Can we revert this change in 2.11 and include it in the next version release?

Naarcha-AWS added a commit that referenced this pull request Nov 28, 2023
Naarcha-AWS added a commit that referenced this pull request Nov 28, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 28, 2023
This reverts commit 4af8a0d.

(cherry picked from commit 3ec0aa4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Naarcha-AWS pushed a commit that referenced this pull request Nov 28, 2023
… (#5687)

This reverts commit 4af8a0d.

(cherry picked from commit 3ec0aa4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Simple-Analysis pushed a commit to Simple-Analysis/documentation-website that referenced this pull request Nov 29, 2023
vagimeli pushed a commit that referenced this pull request Dec 21, 2023
* Including info on OpenID Additional Parameters

Signed-off-by: Sam <samuel.costa@eliatra.com>

* Update _security/authentication-backends/openid-connect.md

Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Signed-off-by: Sam <128482925+samuelcostae@users.noreply.github.com>

* Update _security/authentication-backends/openid-connect.md

Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Signed-off-by: Sam <128482925+samuelcostae@users.noreply.github.com>

* PR feedback changes

Signed-off-by: Sam <samuel.costa@eliatra.com>

---------

Signed-off-by: Sam <samuel.costa@eliatra.com>
Signed-off-by: Sam <128482925+samuelcostae@users.noreply.github.com>
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
vagimeli pushed a commit that referenced this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Doc review PR: Doc review in progress backport 2.11 PR: Backport label for 2.11 OSCI An OSCI contribution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Include "Additional Parameters" support for Open ID
4 participants