Add more settings for Indices Request Cache #7160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiranprakash154
force-pushed
the
kp/tc-settings
branch
from
0e665e4
to
dd14e49
Compare
kiranprakash154
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable,
stephen-crawford and
epugh
as code owners
kiranprakash154
force-pushed
the
kp/tc-settings
branch
from
dd14e49
to
91fe9bc
Compare
hdhalter
added
4 - Doc review
kiranprakash154
commented
May 15, 2024
kiranprakash154
commented
May 15, 2024
| indices.request.cache.store.name: tiered_spillover: true | ||
| indices.request.cache.store.name: tiered_spillover |
There was a problem hiding this comment.
@hdhalter This is a bug
kiranprakash154
commented
May 15, 2024
Comment on lines
94
to
101
| ### Configuring cleanup | ||
|
|
||
| The following table lists the settings related to deletion of stale entries from the cache. | ||
|
|
||
| | Setting | Data type | Default | Description | | ||
| |:-----------------------------------------------------|:----------|:--------|:------------------------------------------------------------------------------------------------------------| | ||
| | `indices.requests.cache.cleanup.staleness_threshold` | String | `0%` | Defines the percentage of stale keys in the cache post which all stale cache entries are deleted. Optional. | | ||
| | `indices.requests.cache.cleanup.interval` | Time unit | `1m` | Defines the frequency at which the request cache's stale entries are deleted. Optional. | |
There was a problem hiding this comment.
These are the changes I'm introducing as new settings
Naarcha-AWS
requested changes
May 16, 2024
|
|
||
| | Setting | Data type | Default | Description | | ||
| |:-----------------------------------------------------|:----------|:--------|:------------------------------------------------------------------------------------------------------------| | ||
| | `indices.requests.cache.cleanup.staleness_threshold` | String | `0%` | Defines the percentage of stale keys in the cache post which all stale cache entries are deleted. Optional. | |
There was a problem hiding this comment.
Suggested change
| | `indices.requests.cache.cleanup.staleness_threshold` | String | `0%` | Defines the percentage of stale keys in the cache post which all stale cache entries are deleted. Optional. | | |
| | `indices.requests.cache.cleanup.staleness_threshold` | String | `0%` | Defines the percentage of stale keys in the cache. After identification, all stale cache entries are deleted. Optional. | |
There was a problem hiding this comment.
I dont think post. All makes sense.
What i meant to say is
Defines the percentage of stale keys in the cache after which all stale cache entries are deleted
kiranprakash154
force-pushed
the
kp/tc-settings
branch
from
3b5b3ea
to
8748d51
Compare
|
Hi @Naarcha-AWS , I have addressed all your comments, can you review again ? |
Naarcha-AWS
reviewed
May 16, 2024
Naarcha-AWS
approved these changes
May 16, 2024
Signed-off-by: Kiran Prakash <awskiran@amazon.com>
Signed-off-by: Kiran Prakash <awskiran@amazon.com>
Signed-off-by: Kiran Prakash <awskiran@amazon.com>
Signed-off-by: Kiran Prakash <awskiran@amazon.com>
Signed-off-by: Kiran Prakash <awskiran@amazon.com>
Signed-off-by: Kiran Prakash <awskiran@amazon.com>
Signed-off-by: Kiran Prakash <awskiran@amazon.com>
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Kiran Prakash <awskiran@amazon.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
kiranprakash154
force-pushed
the
kp/tc-settings
branch
from
66bbae8
to
750f5eb
Compare
Naarcha-AWS
reviewed
May 17, 2024
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 17, 2024
* formatting changes recommended by IDE Signed-off-by: Kiran Prakash <awskiran@amazon.com> * bug fix Signed-off-by: Kiran Prakash <awskiran@amazon.com> * cleanup related entries Signed-off-by: Kiran Prakash <awskiran@amazon.com> * formatting changes recommended by IDE Signed-off-by: Kiran Prakash <awskiran@amazon.com> * cleanup related entries Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update tiered-cache.md Signed-off-by: Kiran Prakash <awskiran@amazon.com> * revert table settings Signed-off-by: Kiran Prakash <awskiran@amazon.com> * cleanup settings Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update _search-plugins/caching/tiered-cache.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> --------- Signed-off-by: Kiran Prakash <awskiran@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> (cherry picked from commit fdf6967) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add more settings related to cleanup of Indices Request Cache
Issues Resolved
#6300
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.