Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependandabot yml file #444

Merged
merged 3 commits into from
Aug 2, 2023

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Aug 2, 2023

Description

Add dependandabot yaml file. Dependandabot should check dependencies weekly and create commits with "dependabot:" prefix

Issues Resolved

Modeled after: opensearch-project/security#2958

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #444 (1e96897) into main (d2e0ac0) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #444   +/-   ##
=========================================
  Coverage     29.19%   29.19%           
  Complexity       98       98           
=========================================
  Files            22       22           
  Lines          1185     1185           
  Branches        109      109           
=========================================
  Hits            346      346           
  Misses          818      818           
  Partials         21       21           

@joshpalis
Copy link
Member

fatal error in thread [main], exiting
�  java.lang.NoClassDefFoundError: org/opensearch/common/lifecycle/LifecycleListener
�  	at java.base/java.lang.Class.getDeclaredConstructors0(Native Method)
�  	at java.base/java.lang.Class.privateGetDeclaredConstructors(Class.java:3373)
�  	at java.base/java.lang.Class.getConstructors(Class.java:2060)
�  	at org.opensearch.plugins.PluginsService.loadPlugin(PluginsService.java:765)

@cwperks
Copy link
Member Author

cwperks commented Aug 2, 2023

Checking to see if bwc tests use SNAPSHOT artifacts

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Copy link
Member Author

cwperks commented Aug 2, 2023

@joshpalis I added -SNAPSHOT to the end of the version before passing it into testClusters. I believe the issue was that it was not using the latest from 2.x in core which includes the LifecycleComponent refactor.

See details about testClusters resolution here: opensearch-project/OpenSearch#8731 (comment)

@saratvemulapalli saratvemulapalli merged commit c2eef64 into opensearch-project:main Aug 2, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants