Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases to dashboards maps #1540

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

junqiu-lei
Copy link
Member

@junqiu-lei junqiu-lei commented Aug 29, 2024

Description

This PR is going to:

Issues Resolved

opensearch-project/dashboards-maps#663

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Junqiu Lei <junqiu@amazon.com>
@junqiu-lei
Copy link
Member Author

Looks the CI isn't able to start up OpenSearch cluster. The test case passed on my forked repo CI:
https://github.com/junqiu-lei/dashboards-maps/actions/runs/10623549472/job/29450177444?pr=21

Copy link
Collaborator

@yujin-emma yujin-emma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raintygao raintygao merged commit e06a6f2 into opensearch-project:main Aug 30, 2024
40 of 59 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 30, 2024
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
(cherry picked from commit e06a6f2)
raintygao pushed a commit that referenced this pull request Aug 30, 2024
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
(cherry picked from commit e06a6f2)

Co-authored-by: Junqiu Lei <junqiu@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants