Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new home ui test for maps #1542

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

junqiu-lei
Copy link
Member

Description

This PR:

  1. Add new home ui test for maps dashboards
  2. Fix failure in add_map_to_dashboard case

Issues Resolved

opensearch-project/dashboards-maps#649
opensearch-project/dashboards-maps#663

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Junqiu Lei <junqiu@amazon.com>
@junqiu-lei
Copy link
Member Author

The github CI failure isn't related to this PR

The Test is verified through https://github.com/junqiu-lei/dashboards-maps/actions/runs/10638937009/job/29495905154?pr=22.


       Spec                                              Tests  Passing  Failing  Pending  Skipped  
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✔  plugins/custom-import-map-dashboard      01:00        1        1        -        -        - │
  │    s/0_add_saved_object.js                                                                     │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/custom-import-map-dashboard      00:59        1        1        -        -        - │
  │    s/1_import_vector_map_tab.spec.js                                                           │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/custom-import-map-dashboard      01:33        1        1        -        -        - │
  │    s/2_opensearchMapLayer.spec.js                                                              │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/custom-import-map-dashboard      01:09        1        1        -        -        - │
  │    s/3_add_saved_object.spec.js                                                                │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/custom-import-map-dashboard      02:38        2        2        -        -        - │
  │    s/4_documentsLayer.spec.js                                                                  │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/custom-import-map-dashboard      01:19        1        1        -        -        - │
  │    s/5_add_map_to_dashboard.spec.js                                                            │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/custom-import-map-dashboard      00:55        1        1        -        -        - │
  │    s/6_geojson_file_upload.spec.js                                                             │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/custom-import-map-dashboard      01:20        2        2        -        -        - │
  │    s/7_enable_new_home_ui.spec.js                                                              │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✔  All specs passed!                        11:00       10       10        -        -        -  

Copy link
Collaborator

@yujin-emma yujin-emma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yujin-emma yujin-emma merged commit 34ba5be into opensearch-project:main Aug 30, 2024
38 of 39 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 30, 2024
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
(cherry picked from commit 34ba5be)
yujin-emma pushed a commit that referenced this pull request Aug 30, 2024
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
(cherry picked from commit 34ba5be)

Co-authored-by: Junqiu Lei <junqiu@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants