Fix Alerts SA tests #1572
Merged
Fix Alerts SA tests #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riya Saxena <riysaxen@amazon.com>
Signed-off-by: Riya Saxena <riysaxen@amazon.com>
Signed-off-by: Riya Saxena <riysaxen@amazon.com>
riysaxen-amzn
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam,
raintygao,
zhongnansu and
yujin-emma
as code owners
Signed-off-by: Riya Saxena <riysaxen@amazon.com>
Signed-off-by: Riya Saxena <riysaxen@amazon.com>
SuZhou-Joe
approved these changes
Sep 13, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
* add ; to tests Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fix channel tests in notifications Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fix integ tests for SA alerts Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fix integ tests for SA alerts Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fix lint errors Signed-off-by: Riya Saxena <riysaxen@amazon.com> --------- Signed-off-by: Riya Saxena <riysaxen@amazon.com> (cherry picked from commit c6217da)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
* add ; to tests Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fix channel tests in notifications Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fix integ tests for SA alerts Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fix integ tests for SA alerts Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fix lint errors Signed-off-by: Riya Saxena <riysaxen@amazon.com> --------- Signed-off-by: Riya Saxena <riysaxen@amazon.com> (cherry picked from commit c6217da)
SuZhou-Joe
pushed a commit
that referenced
this pull request
Sep 14, 2024
* add ; to tests Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fix channel tests in notifications Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fix integ tests for SA alerts Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fix integ tests for SA alerts Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fix lint errors Signed-off-by: Riya Saxena <riysaxen@amazon.com> --------- Signed-off-by: Riya Saxena <riysaxen@amazon.com> (cherry picked from commit c6217da) Co-authored-by: Riya <69919272+riysaxen-amzn@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Sep 14, 2024
* add ; to tests Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fix channel tests in notifications Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fix integ tests for SA alerts Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fix integ tests for SA alerts Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fix lint errors Signed-off-by: Riya Saxena <riysaxen@amazon.com> --------- Signed-off-by: Riya Saxena <riysaxen@amazon.com> (cherry picked from commit c6217da) Co-authored-by: Riya <69919272+riysaxen-amzn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should fill failing alert tests in SA
Issues Resolved
[List any issues this PR will resolve]
opensearch-project/security-analytics-dashboards-plugin#1122
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.