Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security analytics cypress test fixes. #1590

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

AWSHurneyt
Copy link
Contributor

@AWSHurneyt AWSHurneyt commented Oct 17, 2024

Description

  1. Added short wait to help reduce flakiness.
  2. Gave rule unique ID.

Please backport this PR back to v2.17.

Testing

The affected test class passes locally on a 2.17.1 security-enabled domain.
Screenshot 2024-10-17 at 4 22 55 PM

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
@AWSHurneyt
Copy link
Contributor Author

The plugin cypress workflow is failing in the before all function for the test suites (example), suggesting a problem with the environment setup. As mentioned in the PR description, the tests are passing on a 2.17.1 security-enabled domain.

@SuZhou-Joe
Copy link
Member

Backport needed? And do we have any plan to fix the issue that SA cypress test cases can not be run in Github CI.

@AWSHurneyt
Copy link
Contributor Author

Backport needed?

@SuZhou-Joe Yes, please backport this PR to 2.x, and 2.17.

And do we have any plan to fix the issue that SA cypress test cases can not be run in Github CI.

It looks like the CIs are failing in PRs to main branch for other plugins too (example). Considering the tests are failing for multiple plugins in the before all function, It seems to that there's an issue with the test environment brought up as opposed to an issue with the plugins themselves.

Does the functional test repo team have any thoughts on what could be the problem?

@ashwin-pc ashwin-pc merged commit b5b2cb8 into opensearch-project:main Oct 18, 2024
38 of 39 checks passed
@ashwin-pc ashwin-pc added backport 2.x backport 2.17 v2.17.1 Issues targeting release v2.17.1 labels Oct 18, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 18, 2024
* Added short wait to help reduce flakiness.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Gave rule unique ID.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

---------

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
(cherry picked from commit b5b2cb8)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 18, 2024
* Added short wait to help reduce flakiness.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Gave rule unique ID.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

---------

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
(cherry picked from commit b5b2cb8)
kavilla pushed a commit that referenced this pull request Oct 18, 2024
* Added short wait to help reduce flakiness.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Gave rule unique ID.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

---------

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
(cherry picked from commit b5b2cb8)

Co-authored-by: AWSHurneyt <hurneyt@amazon.com>
kavilla pushed a commit that referenced this pull request Oct 18, 2024
* Added short wait to help reduce flakiness.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Gave rule unique ID.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

---------

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
(cherry picked from commit b5b2cb8)

Co-authored-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport 2.17 v2.17.1 Issues targeting release v2.17.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants