Add cypress tests for discover 2.0 #1598
Conversation
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
abbyhu2000
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam,
raintygao,
zhongnansu and
yujin-emma
as code owners
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
abbyhu2000
force-pushed
the
discover_cypress
branch
from
6c0afef
to
b869203
Compare
| cy.get(`[class~="datasetSelector__button"]`).click(); | ||
| cy.get(`[class~="datasetSelector__advancedButton"]`).click(); | ||
| cy.get(`[title="Indexes"]`).click(); | ||
| cy.get(`[title="Default Cluster"]`).click(); | ||
| cy.get(`[title="logstash-2015.09.20"]`).click(); |
There was a problem hiding this comment.
We should use a test ID here. This will be flakey otherwise
| cy.getElementByTestId('queryEditorLanguageSelector').should( | ||
| 'contain', | ||
| 'SQL' | ||
| ); |
There was a problem hiding this comment.
This will be flakey unless we can set this before hand right?
| // The following steps are needed because when selecting SQL, discover loaded with data but the | ||
| // multi-line query editor are not loaded properly(it renders a single line query bar) unless we select SQL again | ||
| // This bug only exist in cypress test; can not reproduce manually | ||
| cy.get(`[data-test-subj="queryEditorLanguageSelector"]`).click(); |
| 'contain', | ||
| 'Step 2: Configure data' | ||
| ); | ||
| // should have two options: SQL and PPL; PPL should be selected |
There was a problem hiding this comment.
How do we ensure this? Wont this be flakey?
There was a problem hiding this comment.
yea it prob be flaky. Will change to click PPL as a option
| ); | ||
| }); | ||
|
|
||
| it('with SQL as default language', function () { |
There was a problem hiding this comment.
Lets be more specific about what this test is doing
| `app/data-explorer/discover#/?_g=(filters:!(),time:(from:'2015-09-19T13:31:44.000Z',to:'2015-09-24T01:31:44.000Z'))` | ||
| ); | ||
|
|
||
| cy.get(`[class~="datasetSelector__button"]`).click(); |
There was a problem hiding this comment.
If there are index patterns, the default index pattern should be selected by default. We should not have to select it
There was a problem hiding this comment.
Yea when i tried it manually, the default index pattern will be picked up by default; but somehow in the test, it wont. @ashwin-pc
| cy.waitForSearch(); | ||
| cy.verifyHitCount(119); | ||
|
|
||
| //query should persist across refresh |
| @@ -34,6 +34,7 @@ | |||
| "osd:ciGroup7": "echo apps/data_explorer/aaa_before.spec.js,apps/data_explorer/doc_navigation.spec.js,apps/data_explorer/doc_table.spec.js,apps/data_explorer/errors.spec.js,apps/data_explorer/field_data.spec.js,apps/data_explorer/zzz_after.spec.js", | |||
| "osd:ciGroup8": "echo apps/data_explorer/aaa_before.spec.js,apps/data_explorer/field_visualize.spec.js,apps/data_explorer/filter_editor.spec.js,apps/data_explorer/index_pattern_with_encoded_id.spec.js,apps/data_explorer/index_pattern_without_field.spec.js,apps/data_explorer/zzz_after.spec.js", | |||
| "osd:ciGroup9": "echo apps/data_explorer/aaa_before.spec.js,apps/data_explorer/inspector.spec.js,apps/data_explorer/large_string.spec.js,apps/data_explorer/saved_queries.spec.js,apps/data_explorer/shared_links.spec.js,apps/data_explorer/sidebar.spec.js,apps/data_explorer/source_filter.spec.js,apps/data_explorer/zzz_after.spec.js", | |||
| "osd:ciGroup10": "echo apps/query_enhancement/*.js", | |||
There was a problem hiding this comment.
Wont this require all the YAML settings and Advanced settings for this view to be set correctly?
There was a problem hiding this comment.
what do you mean by this?
Description
Add two test files to test on discover 2.0 functionalities.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.