Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all dependencies from the migration-console stack #1043

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Remove all dependencies from the migration-console stack #1043

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c332e1e
Remove all dependencies from the migration-console stack
gregschohn Oct 1, 2024
4dd162b
Merge branch 'main' into RemoveSourceAndProxyDependenciesFromMigratio…
gregschohn Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions deployment/cdk/opensearch-service-migration/lib/stack-composer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,10 +621,8 @@ export class StackComposer {
managedServiceSourceSnapshotEnabled,
env: props.env
})
// To enable the Migration Console to make requests to other service endpoints with services,
// it must be deployed after any connected services
this.addDependentStacks(migrationConsoleStack, [captureProxyESStack, captureProxyStack, elasticsearchStack,
openSearchStack, osContainerStack, migrationStack, kafkaBrokerStack])

this.addDependentStacks(migrationConsoleStack, [migrationStack])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like the correct list, I think we accidentally inverted the dependencies when this was first added.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the comment above this as well. Originally when we used service connect to talk between ECS services, the Migration Console would need to be deployed after those services to have their service name mapping with service connect. We no longer user Service Connect I believe so that shouldn't block us.

The other concern I have is loading in environment variables. If we are still loading in environment variables from other stacks that create a source or target (not our import case) say in the opensearch container stack case, we wanted to be sure that endpoint existed and could be passed. This seems like something CDK may be smart enough to detect without manually doing it, but it would be nice to confirm that's the case if we still want to support that use case.

this.stacks.push(migrationConsoleStack)
}

Expand Down