Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat log statements so that they aren't susceptible to formatting errors and worse when {} are in the message #1084

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Commits on Oct 19, 2024

  1. Reformat log statements so that they aren't susceptible to formatting…

    … errors and worse when {} could end up directly in the 'message' string.
    
    I tried to codify on a couple of standards as well.
    1) setMessage(Supplier...) should not be used.  Placeholders and arguments should always be used instead.
    2) All arguments being added should use a supplier if the argument requires any evaluation of a function.  To confirm, the regex `.addArgument\([^\(\)]+\([^\)]*` shouldn't found present.
    
    On stylistic levels
    3) The sequence of fluent/builder operations should be setCause, setMessage, addArguments...
    4) If more than one argument is added, each argument should be on a separate line, followed by a log() also on its own line.
    
    Signed-off-by: Greg Schohn <greg.schohn@gmail.com>
    gregschohn committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    99d5290 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Configuration menu
    Copy the full SHA
    0f37d99 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Revert some temporary log substitution strings that were over-applied…

    … in an earlier commit
    
    Signed-off-by: Greg Schohn <greg.schohn@gmail.com>
    gregschohn committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    5e89383 View commit details
    Browse the repository at this point in the history