Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unspecified dependencies in maven pom publishing #1100

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

AndreKurait
Copy link
Member

@AndreKurait AndreKurait commented Oct 23, 2024

Description

Remove unspecified dependencies in maven pom publishing

We were having one dependency that was unspecified opentelemetry-testing because it was only used in a testFixtures and wasn't in the resolution classpath. Fixed that and added a check before publishing that all versions are specified.

  • Category: Bug Fix
  • Why these changes are required? Usable Maven Pom files
  • What is the old behavior before changes and new behavior after changes? opentelemetry-testing didn't include a version

Issues Resolved

N/A

Is this a backport? If so, please add backport PR # and/or commits #

Testing

ran ./gradlew publishToMavenLocal

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.66%. Comparing base (db0075e) to head (05ac28d).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1100      +/-   ##
============================================
- Coverage     80.66%   80.66%   -0.01%     
+ Complexity     2893     2892       -1     
============================================
  Files           383      383              
  Lines         14361    14359       -2     
  Branches        989      989              
============================================
- Hits          11584    11582       -2     
+ Misses         2184     2183       -1     
- Partials        593      594       +1     
Flag Coverage Δ
gradle-test 78.74% <ø> (-0.01%) ⬇️
python-test 90.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Andre Kurait <akurait@amazon.com>
Copy link
Collaborator

@gregschohn gregschohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, assuming that you'll get to the two comments that I've added.

build.gradle Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
Signed-off-by: Andre Kurait <akurait@amazon.com>
@AndreKurait AndreKurait merged commit d45835d into opensearch-project:main Oct 24, 2024
14 checks passed
@AndreKurait AndreKurait deleted the FixMavenPom branch October 24, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants