Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed as Duplicate - Enhancements in StreamChannelConnectionCaptureSerializer #493

Closed
wants to merge 2 commits into from

Conversation

AndreKurait
Copy link
Member

@AndreKurait AndreKurait commented Jan 30, 2024

I'm closing this pull request as the changes have been moved to a new branch and a new pull request has been opened here.

Description

This pull request introduces two key enhancements to the StreamChannelConnectionCaptureSerializer:

  • Refactoring the StreamChannelConnectionCaptureSerializerTest with a calculated bufferSize.
  • Increasing the StreamChannelConnectionCaptureSerializer's max ID size.
  • Category: Bug fix, Refactoring
  • These changes are required to fix max id size assertion in StreamChannelConnectionCaptureSerializer which currently is not large enough to allow for kafka connectionIds when executed with assertions enabled.
  • Old behavior: Threw assertion error when starting up with -ea jdk flag.
  • New behavior: No StreamChannelConnectionCaptureSerializer assertion error during startup with -ea.

Issues Resolved

Is this a backport? If so, please add backport PR # and/or commits #

  • N/A

Testing

  • Unit testing have been conducted to ensure functionality with new tests added to verify behavior
  • Manual testing has been performed to verify the changes via starting up dockerSolution with -enableassertions with OSB --test script and doc count check

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • [N/A] New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andre Kurait <akurait@amazon.com>
… bufferSize

Signed-off-by: Andre Kurait <akurait@amazon.com>

Signed-off-by: Andre Kurait <akurait@amazon.com>
@AndreKurait AndreKurait changed the title Enhancements in StreamChannelConnectionCaptureSerializer Closed as Duplicate - Enhancements in StreamChannelConnectionCaptureSerializer Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant