Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in TimeShifter comments #504

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

AndreKurait
Copy link
Member

@AndreKurait AndreKurait commented Feb 8, 2024

Description

Fix typo in TimeShifter comments

  • Category: Maintenance
  • Why these changes are required? Mitigate miscommunication with incorrect code comments
  • What is the old behavior before changes and new behavior after changes? No behavior change

Issues Resolved

N/A

Is this a backport? If so, please add backport PR # and/or commits #
N/A

Testing

Pipeline tests, no functional change

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andre Kurait <akurait@amazon.com>
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (47e1cf3) 76.45% compared to head (023840a) 75.28%.
Report is 31 commits behind head on main.

❗ Current head 023840a differs from pull request most recent head 5c09873. Consider uploading reports for the commit 5c09873 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #504      +/-   ##
============================================
- Coverage     76.45%   75.28%   -1.17%     
+ Complexity     1375     1355      -20     
============================================
  Files           158      158              
  Lines          6085     6085              
  Branches        530      530              
============================================
- Hits           4652     4581      -71     
- Misses         1075     1149      +74     
+ Partials        358      355       -3     
Flag Coverage Δ
unittests 75.28% <100.00%> (-1.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gregschohn gregschohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please shift the indents to 4 spaces to be consistent with the rest of the file.

@AndreKurait AndreKurait deleted the typo-fix branch February 13, 2024 21:18
@AndreKurait AndreKurait restored the typo-fix branch February 14, 2024 04:46
@AndreKurait AndreKurait reopened this Feb 14, 2024
@AndreKurait AndreKurait merged commit 772facc into opensearch-project:main Feb 16, 2024
4 of 5 checks passed
@AndreKurait AndreKurait deleted the typo-fix branch February 16, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants