-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slow test fixup #509
Slow test fixup #509
Conversation
Signed-off-by: Andre Kurait <akurait@amazon.com>
Signed-off-by: Andre Kurait <akurait@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #509 +/- ##
============================================
+ Coverage 76.45% 76.71% +0.26%
- Complexity 1375 1385 +10
============================================
Files 158 158
Lines 6085 6086 +1
Branches 530 532 +2
============================================
+ Hits 4652 4669 +17
+ Misses 1075 1059 -16
Partials 358 358
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are you limiting these tests to NOT run for the test target?
@Retention(RetentionPolicy.RUNTIME) | ||
@Target({ElementType.TYPE}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are these lines doing here? Why do you need them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Java by default only adds annotations to the .class file and are not loaded at runtime, for Junit Tags to work, these annotations need to be included at runtime.
The inner |
Description
Increase reliability of capture proxy tests by correctly passing longTest tag and lowering concurrency to numberOfCores/2
Issues Resolved
N/A
Is this a backport? If so, please add backport PR # and/or commits #
N/A
Testing
Tested with gradle test to ensure tests are not being run
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.