Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow test fixup #509

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Conversation

AndreKurait
Copy link
Member

Description

Increase reliability of capture proxy tests by correctly passing longTest tag and lowering concurrency to numberOfCores/2

  • Category: Test Fix
  • Why these changes are required? Currently, proxy tests are running for both slow test
  • What is the old behavior before changes and new behavior after changes? Current, KafkaConfigurationCaptureProxyTest tests run for both test and slowTest tasks which is not desired, new behavior is that KafkaConfigurationCaptureProxyTest only runs with SlowTest with dynamic parallelization in half.

Issues Resolved

N/A

Is this a backport? If so, please add backport PR # and/or commits #
N/A

Testing

Tested with gradle test to ensure tests are not being run

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andre Kurait <akurait@amazon.com>
Signed-off-by: Andre Kurait <akurait@amazon.com>
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (47e1cf3) 76.45% compared to head (c253aa8) 76.71%.
Report is 36 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #509      +/-   ##
============================================
+ Coverage     76.45%   76.71%   +0.26%     
- Complexity     1375     1385      +10     
============================================
  Files           158      158              
  Lines          6085     6086       +1     
  Branches        530      532       +2     
============================================
+ Hits           4652     4669      +17     
+ Misses         1075     1059      -16     
  Partials        358      358              
Flag Coverage Δ
unittests 76.71% <ø> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gregschohn gregschohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are you limiting these tests to NOT run for the test target?

Comment on lines +12 to +13
@Retention(RetentionPolicy.RUNTIME)
@Target({ElementType.TYPE})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these lines doing here? Why do you need them?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java by default only adds annotations to the .class file and are not loaded at runtime, for Junit Tags to work, these annotations need to be included at runtime.

@AndreKurait
Copy link
Member Author

How are you limiting these tests to NOT run for the test target?

The inner @TestContainerTest defines the @tag("longTest") which is excluded from the test task.

@AndreKurait AndreKurait merged commit 7dac332 into opensearch-project:main Feb 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants