Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make globally unique default bucket name #514

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

AndreKurait
Copy link
Member

Description

Changing default S3 bucket name to be globally unique given S3 naming constraints via adding in account name.

  • Category - Bug Fix
  • Why these changes are required? S3 buckets will fail to be created if not globally unique.
  • What is the old behavior before changes and new behavior after changes? Before, no account name in bucket name, collisions can occur if multiple deployments happen with same stage name and region across any customer.

Issues Resolved

N/A

Is this a backport? If so, please add backport PR # and/or commits #
N/A

Testing

Ran CDK Diff on a stack where this was already deployed previously.

Stack migrationInfraStack (OSMigrations-dev-us-west-2-MigrationInfra)
Creating a change set, this may take a while...
Resources
[~] AWS::S3::Bucket migrationArtifactsS3 migrationArtifactsS35D99BC6A replace
 └─ [~] BucketName (requires replacement)
     ├─ [-] migration-artifacts-dev-us-west-2
     └─ [+] migration-artifacts-905418235891-dev-us-west-2
[~] AWS::S3::BucketPolicy migrationArtifactsS3/Policy migrationArtifactsS3PolicyBD77C90F replace
 └─ [~] Bucket (requires replacement)
     └─ [~] .Ref:
         ├─ [-] migrationArtifactsS35D99BC6A
         └─ [+] migrationArtifactsS35D99BC6A (replaced)

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andre Kurait <akurait@amazon.com>
@AndreKurait AndreKurait merged commit 591a7bb into opensearch-project:main Feb 19, 2024
5 checks passed
@AndreKurait AndreKurait deleted the S3BucketNameFix branch February 19, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants