Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for textFixtures imports with maven local publishing #524

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

AndreKurait
Copy link
Member

Description

Add support for textFixtures imports with maven local publishing

  • Category: Enhancement
  • Why these changes are required? Allow external projects to use testFixtures
  • What is the old behavior before changes and new behavior after changes? TestFixtures did not work to import.

Issues Resolved

MIGRATIONS-1508

Is this a backport? If so, please add backport PR # and/or commits #
No

Testing

Created separate project locally to test the testFixtures

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andre Kurait <akurait@amazon.com>
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.80%. Comparing base (e7e37a1) to head (9fedef8).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #524      +/-   ##
============================================
- Coverage     76.82%   76.80%   -0.02%     
- Complexity     1386     1388       +2     
============================================
  Files           158      158              
  Lines          6105     6105              
  Branches        532      532              
============================================
- Hits           4690     4689       -1     
- Misses         1063     1065       +2     
+ Partials        352      351       -1     
Flag Coverage Δ
unittests 76.80% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndreKurait AndreKurait merged commit aff1b80 into opensearch-project:main Feb 27, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants